Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Yeets ATTACK_QDELETED, fixes welding torches not using fuel on attacking non-mobs (2 year old bug) #2932

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#2030
Original PR: tgstation/tgstation#82694

About The Pull Request

  • Deletes ATTACK_QDELETED

    • May have been necessary in the past but it's pointless now. All it does is clutter the attack chain. Perish.
  • Fixes welders not using fuel on attacking non-mobs

    • #65762 "fixed" welders consuming fuel on clicking turfs by adding an isliving check and not an ismovable check?

Changelog

🆑 Melbert
fix: Blobs may rejoice, welding torches now consume fuel when attacking objects again after two years.
/:cl:

…l on attacking non-mobs (2 year old bug) (#2030)

* Yeets `ATTACK_QDELETED`, fixes welding torches not using fuel on attacking non-mobs (2 year old bug)  (#82694)

## About The Pull Request

- Deletes `ATTACK_QDELETED`
- May have been necessary in the past but it's pointless now. All it
does is clutter the attack chain. Perish.

- Fixes welders not using fuel on attacking non-mobs
- #65762 "fixed" welders consuming fuel on clicking turfs by adding an
`isliving` check and not an `ismovable` check?


## Changelog

:cl: Melbert
fix: Blobs may rejoice, welding torches now consume fuel when attacking
objects again after two years.
/:cl:

* Yeets `ATTACK_QDELETED`, fixes welding torches not using fuel on attacking non-mobs (2 year old bug)

* Electric welders are hot too now. Starting fires is definitely in their wheelhouse

---------

Co-authored-by: MrMelbert <[email protected]>
Co-authored-by: Mal <[email protected]>
@Iajret Iajret merged commit 44e76a7 into master Apr 17, 2024
27 checks passed
@Iajret Iajret deleted the upstream-mirror-2030 branch April 17, 2024 12:11
AnywayFarus added a commit that referenced this pull request Apr 17, 2024
Iajret pushed a commit that referenced this pull request Jun 9, 2024
* Fix coders leaving coderbus (#83791)

## About The Pull Request

The coders on the coderbus are now anchored to the seats and can't be
taken to the station

## Why It's Good For The Game

Coders don't play

## Changelog

:cl: Melbert
balance: Coders are now locked to the coderbus
/:cl:

* Fix coders leaving coderbus

---------

Co-authored-by: MrMelbert <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants