[MIRROR] Quirks, which give items, now have quirk_item arg specified as obj/item, instead of being just a var #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as obj/item, instead of being just a var (#2035) * Quirks, which give items, now have quirk_item arg specified as obj/item, instead of being just a var (#82650) ## About The Pull Request quirk_item is now /obj/item, since it will allow for calling procs or getting variables from this item It's required for non-modular translation to call for item's name to remove articles ## Why It's Good For The Game It's always an item, and if it's a path, it's already checked for it. Better usage in the future. * Quirks, which give items, now have quirk_item arg specified as obj/item, instead of being just a var --------- Co-authored-by: larentoun <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Jun 9, 2024
* Fixes basic bots being targeted by turrets (#83777) turret faction got removed by accident. fixes #83747 🆑 ShizCalev fix: Basic bots are now in the proper faction and will no longer be targeted by turrets. /🆑 * Fixes basic bots being targeted by turrets --------- Co-authored-by: Afevis <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#2035
Original PR: tgstation/tgstation#82650
About The Pull Request
quirk_item is now /obj/item, since it will allow for calling procs or getting variables from this item
It's required for non-modular translation to call for item's name to remove articles
Why It's Good For The Game
It's always an item, and if it's a path, it's already checked for it. Better usage in the future.