Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Re-enables borg resizing for Tall/Wide with more aggressive limits #2944

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#1687

About The Pull Request

The removal a while back was met with almost negatives across the board from borg players, so i'm re-introducing it but with more reasonable size changes.

Wide Borgs (Quadsborgs):

  • Shrink module: 90% Up from 75%
  • Expand module: 125% Down from 150%

Ironically the quads had the opposite issue that tallborgs had where the small difference made them have really weird pixel bars show up.

Ordering in the pictures are top to bottom: Expand | Normal | Shrink

Tall Borgs (Nikas/Nikos/Mekas/CATTES):

  • Shrink: 95% Up from 75%
  • Expand: 105% Down from 150%

The scalers going on the Y axes give a much harsher and more dramatic change than the X axis like wides have, and given they're already fairly tall we're going to go with a tamer but still fairly noticable sprite difference.

Small_trait borgs (Default/Borgi)

  • Unchanged currently - they get the 125% increase but are locked from the decrease due to turning microscopic

Ordering in the pictures are left to right: Shrink | Normal | Expand

image

Other angles/with HUDS

image

image

How This Contributes To The Nova Sector Roleplay Experience

We have some rather dramatic size options now, from Oversized to dwarf, this brings back the ability to at-a-glance differentiate borgs who share the same skin within a shift if they choose to use one of these options.

Proof of Testing

Screenshots/Videos See Description

Changelog

🆑 Zergspower
qol: re-enabled Borg Resizing for wide and tall borgs
/:cl:

@ReezeBL ReezeBL merged commit 52cc8f9 into master Apr 18, 2024
27 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-1687 branch April 18, 2024 07:40
AnywayFarus added a commit that referenced this pull request Apr 18, 2024
Iajret pushed a commit that referenced this pull request Jun 9, 2024
#2944)

* Contractor baton excluded from TBaton spy bounty (#83803)

## About The Pull Request
The game adds the Contractor Baton to the "global tracker" whatever the
hell that is, from what I understand it's what determines the potential
bounty item pool, since the contractor baton is a subtype of the
telescopic baton; Which of course is not very appropriate considering
the baton came from the Syndicate in the first place. The code excludes
all subtypes of the telescopic baton so that we don't get something
goofy like this:

![aJboHU3](https://github.com/tgstation/tgstation/assets/125638858/a581ccbb-480c-4090-825e-a661a87e1a50)
Credit: _shod for the image
## Why It's Good For The Game
When problem is fixed, problem no longer bad.

Originally I wanted to just add a custom text saying what a contractor
baton is instead of the telescopic baton, but was told it's not a good
idea. Boowomp. Anyways, stealing back a contractor baton from the
Syndicate who just GAVE someone that baton is a little weird I
suppooosseee.....
## Changelog
:cl:
fix: You may no longer submit, or obtain, a spy bounty for the
contractor baton.
/:cl:

* Contractor baton excluded from TBaton spy bounty

---------

Co-authored-by: IsaacExists <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants