Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] [SEMI-MODULAR] Forbids synth electrical damage from getting worse if they are currently being repaired #2946

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#1960

About The Pull Request

Alternative to NovaSector/NovaSector#1959

I always intended to do this, I just never got around to it.

As a side, decreases effectiveness of repair methods that were inflated during design becuase of this exact issue.

How This Contributes To The Nova Sector Roleplay Experience

It becomes a bit of a design headache to work around this, plus it kinda makes it really hard for these things to be fixed.

Proof of Testing

Screenshots/Videos

im not sure how to prove this other than it compiled. screenshots dont really show it

Changelog

🆑 nikothedude
add: Synthetic electrical damage can no longer worsen if its currently being repaired
/:cl:

…they are currently being repaired (#1960)

* dwawd

* womp

* woo

* Apply suggestions from code review

---------

Co-authored-by: Bloop <[email protected]>
@ReezeBL ReezeBL merged commit f499699 into master Apr 18, 2024
27 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-1960 branch April 18, 2024 07:41
AnywayFarus added a commit that referenced this pull request Apr 18, 2024
Iajret pushed a commit that referenced this pull request Jun 9, 2024
…DB IGNORE] (#2946)

* Fixes certain quirks being erased by slimeperson cloning. (#83793)

## About The Pull Request
Certain quirks like Signer get erased by slimeperson body splitting due
to improper usage of add_unique. This should fix that.
## Why It's Good For The Game
bugs bad
## Changelog
:cl:
fix: Fixes certain quirks being erased by slimeperson cloning.
/:cl:

* Fixes certain quirks being erased by slimeperson cloning.

---------

Co-authored-by: NewyearnewmeUwu <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants