[MIRROR] Fixes tgui alert buttons #2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes tgui alert buttons (#82714) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Been on my mind for a long time I did this while relatively inexperienced (how do I center a div etc) Fixes an issue inherent to our stack implementation where reversing the direction caused strange spacing issues. This effectively reverses the extra margins in css so it looks identically spaced whether reversed/not <details> <summary>before/after</summary> Before (normal buttons)  Before (large buttons)  After (normal buttons)  After (large buttons)  Long buttons (normal)  Long buttons (large buttons (I am 35 and yet still fight the forces of chaos))  </details> <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Looks better, runs smoother, no clipping <!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. --> ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> :cl: fix: TGUI Alerts shouldn't have such wonky buttons any more /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: lessthanthree <[email protected]> * Fixes tgui alert buttons --------- Co-authored-by: Jeremiah <[email protected]> Co-authored-by: lessthanthree <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Apr 19, 2024
Iajret
pushed a commit
that referenced
this pull request
Jun 9, 2024
…rk [MDB IGNORE] (#2950) * Changeling Rebalance: Kill It With Fire, feat. Armblade Rework (#83616) ## About The Pull Request https://github.com/tgstation/tgstation/assets/4081722/684da396-fb28-4022-9f46-0fc4feb34b7a Changelings now do not like fire, as is tradition. If they are on fire, they no longer generate chemicals until they put the fire out. If they are on fire, they no longer can use any changeling powers until they put the fire out. All changeling equippable items like armblades, shields, armor, spacesuits, etc. are now flammable and super-duper vulnerable to flames. The Armblade now costs 30 chemicals to equip, and has a DNA cost of 3, compared to the previous 20 chemicals and 2 DNA cost. The Armblade now shatters after enough uses in exactly the same way as the Shield; extract genomes with Absorb to maximize your Armblade's efficiency. for its' chemical cost. Fixes items you're holding not catching on fire alongside the rest of you when you light on fire. Fixes the Changeling Shield having one more hit than it was supposed to. ## Why It's Good For The Game Changeling has been in a relatively incredibly rough state ever since someone walked up to this predominatly stealth and intrigue based antagonist and went "lets turn it into a carbon copy of an early 2000s action game I just played".  Since then, just about every changeling has been a loud changeling. The stats speak for themselves; Changelings are no longer a stealth antag and they're defined by having an undroppable e-sword, armor, and HP regen they can use mid-fight. They're just loud beatsticks now instead of the scary stealth antagonist they were years ago. I'm expecting a lot of pushback from the adrenaline addicts who dislike the concept of stealth, to which I say: too bad. Giving Changelings a weak point in the form of fire is not only thematically appropriate for the original inspiration for Changeling, but also provides the crew a way to actually scare off changelings back into hiding, and encourages more usage of fire-causing weapons. This is going to shake up changelings, and Nerfing the hell out of the Armblade is going to encourage changelings to take stealthier approaches to combat, and utilize the rest of their power assortment that isn't just focused around being a gigantic unstoppable beatstick. ## Changelog :cl: balance: Changelings now do not like fire, as is tradition. balance: If they are on fire, they no longer generate chemicals until they put the fire out. balance: If they are on fire, they no longer can use any changeling powers until they put the fire out. balance: All changeling equippable items like armblades, shields, armor, spacesuits, etc. are now flammable and super-duper vulnerable to flames. balance: The Armblade now costs 30 chemicals to equip, and has a DNA cost of 3, compared to the previous 20 chemicals and 2 DNA cost. add: The Armblade now shatters after enough uses in exactly the same way as the Shield; extract genomes with Absorb to maximize your Armblade's efficiency. for its' chemical cost. fix: Fixes items you're holding not catching on fire alongside the rest of you when you light on fire. fix: Fixes the Changeling Shield having one more hit than it was supposed to. /:cl: --------- Co-authored-by: MrMelbert <[email protected]> * Changeling Rebalance: Kill It With Fire, feat. Armblade Rework --------- Co-authored-by: Iamgoofball <[email protected]> Co-authored-by: MrMelbert <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#2064
Original PR: tgstation/tgstation#82714
About The Pull Request
Been on my mind for a long time
I did this while relatively inexperienced (how do I center a div etc)
Fixes an issue inherent to our stack implementation where reversing the direction caused strange spacing issues. This effectively reverses the extra margins in css so it looks identically spaced whether reversed/not
before/after
Before (normal buttons)
Before (large buttons)
After (normal buttons)
After (large buttons)
Long buttons (normal)
Long buttons (large buttons (I am 35 and yet still fight the forces of chaos))
Changelog
🆑 jlsnow301
fix: TGUI Alerts shouldn't have such wonky buttons any more
/:cl: