[MIRROR] Fixes smart pipe & cryo gas reallocation #2954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes smart pipe & cryo gas reallocation (#82701) ## About The Pull Request **1. Smart Pipe Problem** - Fill a pipe with any gas, plasma for e.g. - Unwrench the pipe to deconstruct - The pressure sends you flying but notice plasma is nowhere to be seen from the now destroyed pipe **2. Cryo pipe connector problem** The gas gets reallocated when the object is deleted. We only want this when its deconstructed not deleted to prevent any side effects This PR fixes them ## Changelog :cl: fix: smart pipes release their gases into the air when unwrenched fix: cryo pipe connector component has no side effects of gas reallocation when deleted /:cl: * Fixes smart pipe & cryo gas reallocation --------- Co-authored-by: SyncIt21 <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Apr 19, 2024
Iajret
pushed a commit
that referenced
this pull request
Jun 10, 2024
* ERT_Bounty.DMM ship touchup (#83608) ## About The Pull Request It updates this shuttle to make it better! I'll be honest, I don't _actually_ know what this is used for. Maybe an admin button makes this spawn? I'm not sure. Eitherway, it's better now. ## Why It's Good For The Game This place looks better; mapping improvement. ## Changelog :cl: qol: The ERT's ship has better mapping now. /:cl: * ERT_Bounty.DMM ship touchup --------- Co-authored-by: Fazzie <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#2070
Original PR: tgstation/tgstation#82701
About The Pull Request
1. Smart Pipe Problem
2. Cryo pipe connector problem
The gas gets reallocated when the object is deleted. We only want this when its deconstructed not deleted to prevent any side effects
This PR fixes them
Changelog
🆑 SyncIt21
fix: smart pipes release their gases into the air when unwrenched
fix: cryo pipe connector component has no side effects of gas reallocation when deleted
/:cl: