[MIRROR] Minor tweaks to forged tools #2966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* changes * comment
AnywayFarus
added a commit
that referenced
this pull request
Apr 19, 2024
Iajret
pushed a commit
that referenced
this pull request
Jun 11, 2024
* Icebox Visitation Floor Fix (#83816) ## About The Pull Request Adds in the single missing floor from Icebox's visitation room connected to the cell area, south of the lower Armory. To be honest I thought this was intentional destruction at first. Before:  After:  ## Why It's Good For The Game Oh no! Maintenance tiles in MY Icebox brig? This just cannot stand. Station's prettier without this missing tile. ## Changelog :cl: fix: Eastern icebox visitation door no longer missing a floor tile. /:cl: * Icebox Visitation Floor Fix --------- Co-authored-by: IsaacExists <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#2013
About The Pull Request
Makes forged daggers act as knives and changes the toolspeed on forged items to work like literally every other tool's toolspeed (it used the SECONDS define instead of treating the toolspeed var like a modifier like everything else does?), with accompanying changes to not make billowing/hammering obscenely fast. Forged items also have a slightly faster toolspeed than the base as well (0.9 versus 1), because a hand-crafted tool should be better than one made in the autolathe.
How This Contributes To The Nova Sector Roleplay Experience
Not being able to use a knife as.. a knife is kind of silly, and this will also give the opportunity for, say, chefs to commission people smithing for a higher-quality tool - even if it's a slight difference.
Proof of Testing
Screenshots/Videos
Changelog
🆑 JimKil3
add: Forged daggers now act as knives
add: Forged tools are now slightly faster than default
code: Forging-related tools now use the toolspeed var normally
/🆑