Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Use cell defined constants for various stuff #2983

Merged
merged 2 commits into from
Apr 20, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#2063
Original PR: tgstation/tgstation#82594

About The Pull Request

This re writes most cell power usage cases with 2 defines STANDARD_CELL_CHARGE(Joules) & STANDARD_CELL_RATE(Watts) so changing cell capacity values in the future won't cause discrepancies.

Changelog

🆑 SyncIt21
code: most cell power usages are scaled with defined constants to help adapt to future changes
/:cl:

Use cell defined constants for various stuff

Co-authored-by: SyncIt21 <[email protected]>
Co-authored-by: Bloop <[email protected]>
@Steals-The-PRs Steals-The-PRs added Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота TG Mirror labels Apr 20, 2024
@Iajret Iajret merged commit 37b3a6d into master Apr 20, 2024
25 checks passed
AnywayFarus added a commit that referenced this pull request Apr 20, 2024
@Iajret Iajret deleted the upstream-mirror-2063 branch April 22, 2024 10:45
Iajret pushed a commit that referenced this pull request Jun 12, 2024
Adds some shuttle wreckage (Lavaland Ruin)

Co-authored-by: r3dj4ck0424 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота TG Mirror
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants