[MIRROR] Plumbing machinery power & processing tweaks #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plumbing machinery power & processing tweaks Co-authored-by: SyncIt21 <[email protected]> Co-authored-by: Bloop <[email protected]>
Steals-The-PRs
added
Mirroring conflict
…into upstream-mirror-2089
AnywayFarus
added a commit
that referenced
this pull request
Apr 20, 2024
Iajret
pushed a commit
that referenced
this pull request
Jun 12, 2024
…anup better [MDB IGNORE] (#2985) * Warns for genturf failures more clearly, makes planetary cleanup better (#83809) ## About The Pull Request Ok so like, we recently had an issue where a genturf was not being replaced, which fucked ALL of icemoon's atmosphere. The fix was to not use a genturf with a conditionally generating area, but that aside. (why is it CONDITIONAL TIME GREEEEEN) Planetary turfs should act like immutable ones when roundstart equalizing. In addition, we should test to ensure none leaves genturfs floating around post roundstart to avoid this sorta issue. --------- Co-authored-by: Afevis <[email protected]> * Warns for genturf failures more clearly, makes planetary cleanup better --------- Co-authored-by: LemonInTheDark <[email protected]> Co-authored-by: Afevis <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#2089
Original PR: tgstation/tgstation#82702
About The Pull Request
Plumbing machinery begins processing only when wrenched & ends processing when unwrenched. The machines plumbing component
/datum/component/plumbing/process()already does this but the underlying machines processing proc for e.g./obj/machinery/plumbing/synthesizer/process()is always processing regardless of its wrenched state or not. We can optimize this & save power when unwrenchedFixes #82621. This adds plumbing machines
idle_power_usageon top of itsactive_power_usageensuring it only uses power when actively doing work, So if your factory is say full of reagents & cannot do any more work it will use less energy i.e almost enter an stand by mode, efficiencyPlumbing grinder chemical will grinds & juice stuff correctly i.e. prefer grinding over juicing most of the time
Changelog
🆑 SyncIt21
fix: plumbing machinery begins processing only when wrenched & ends when unwrenched
fix: plumbing machinery uses energy only when wrenched & doing work, will stop/use less energy when idle
fix: plumbing grinder chemical will grinds & juice stuff correctly i.e. prefer grinding over juicing for most stuff
/:cl: