[MIRROR] Makes dropdowns better #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Makes dropdowns better (#82697) ## About The Pull Request Kind of a pain to work with, confusing people with its prop names (many such cases!) After recently discovering deathmatch it's very obvious to me how broken it is, so I made it less so (now comes with a complete ui upgrade!) It now scrolls with the selection and to the selection on open, which felt like major QoL <details> <summary>pics/vids</summary> In motion  Deathmatch got some UI facelifts   Fixes #75741  </details> ## Why It's Good For The Game Better UX Bug fixes Potential exploit patched (ui validation for ai voice changer) Fixes #81506 ## Changelog :cl: fix: Dropdowns received some much-needed QoL, like having the scrollbar follow your selection. fix: AI voice changer now shows its current voice selection. fix: Deathmatch screen has been touched up. fix: Prefs menu has their dropdowns simplified, hopefully fixing issues /:cl: --------- Co-authored-by: san7890 <[email protected]> * Makes dropdowns better * Initial pass, things still broken * Initial pass, things still broken * Update LimbsPage.tsx --------- Co-authored-by: Jeremiah <[email protected]> Co-authored-by: san7890 <[email protected]> Co-authored-by: Mal <[email protected]>
…into upstream-mirror-2078
AnywayFarus
added a commit
that referenced
this pull request
Apr 21, 2024
Iajret
pushed a commit
that referenced
this pull request
Jun 16, 2024
* Afterattack is dead, long live Afterattack * Modular updates pt 1 * Fixes blood magic applying wounds when casted (#73170) Fixes cult blood magic applying wounds to the users hand when casted * afterattack is dead, aughhhh * this is totally unrelated but whatever * reset a couple diffs --------- Co-authored-by: MrMelbert <[email protected]> Co-authored-by: Mal <[email protected]> Co-authored-by: SuperSlayer <[email protected]> Co-authored-by: Fluffles <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#2078
Original PR: tgstation/tgstation#82697
About The Pull Request
Kind of a pain to work with, confusing people with its prop names (many such cases!)
After recently discovering deathmatch it's very obvious to me how broken it is, so I made it less so
(now comes with a complete ui upgrade!)
It now scrolls with the selection and to the selection on open, which felt like major QoL
pics/vids
In motion
Deathmatch got some UI facelifts
Fixes #75741
Why It's Good For The Game
Better UX
Bug fixes
Potential exploit patched (ui validation for ai voice changer)
Fixes #81506
Changelog
🆑 jlsnow301
fix: Dropdowns received some much-needed QoL, like having the scrollbar follow your selection.
fix: AI voice changer now shows its current voice selection.
fix: Deathmatch screen has been touched up.
fix: Prefs menu has their dropdowns simplified, hopefully fixing issues
/:cl: