Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Remove shapeshift if the mob tries to turn into a different mob #309

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24612
Original PR: tgstation/tgstation#79270

About The Pull Request

Fixes #78250

Bileworms, baby chicks, and various kinds of young spider automatically try to change into a different mob after some time.
This bricks shapeshift spells because you can't transform back after being turned into another kind of mob (and sometimes also ghosts you by deleting your original body).
Now we have a signal before we try to call change_type on a mob which is intercepted by the shapeshift status effect and cancels both things.

Unfortunately this doesn't make turning into a Bileworm fun to play, their movement is always random because it's designed for an AI not a player 😔

Changelog

🆑 Jacquerel
fix: If a mob you are shapeshifted into attempts to grow up into a different kind of mob then you will stop being shapeshifted
/:cl:

…mob [MDB IGNORE] (#24612)

* Remove shapeshift if the mob tries to turn into a different mob (#79270)

## About The Pull Request

Fixes #78250

Bileworms, baby chicks, and various kinds of young spider automatically
try to change into a different mob after some time.
This bricks shapeshift spells because you can't transform back after
being turned into another kind of mob (and sometimes also ghosts you by
deleting your original body).
Now we have a signal before we try to call `change_type` on a mob which
is intercepted by the shapeshift status effect and cancels both things.

Unfortunately this doesn't make turning into a Bileworm fun to play,
their movement is always random because it's designed for an AI not a
player 😔

## Changelog

:cl:
fix: If a mob you are shapeshifted into attempts to grow up into a
different kind of mob then you will stop being shapeshifted
/:cl:

* Remove shapeshift if the mob tries to turn into a different mob

---------

Co-authored-by: Jacquerel <[email protected]>
@Iajret Iajret merged commit 040ec5d into master Oct 27, 2023
23 checks passed
@Iajret Iajret deleted the upstream-mirror-24612 branch October 27, 2023 13:54
AnywayFarus added a commit that referenced this pull request Oct 27, 2023
Iajret pushed a commit that referenced this pull request Jan 4, 2024
…aces brains with other organs (#309)

* [NO GBP] Fixes path of moon and path of lock sidepaths, replaces brains with other organs (#80730)

## About The Pull Request

This pull request makes the paths as follows:
Rust<>Cosmic<>Ash<>Moon<>Lock<>Flesh
This means flesh and ash are no longer adjacent and their old sidepaths
is now between moon and ash
Apetra Vulnera has been moved up one tier and is now unlocked at
caretakers refuge/stalker for lock/flesh.
## Why It's Good For The Game
Heretic paths should actually fit with each other and this ensures that
it does. As for the removal of brains from certain rituals it is a very
difficult organ to obtain as opposed to the rest of the bunch and we are
moving towards a direction of making brains even harder to obtain so
this ensures those rituals still stay relevant.
## Changelog
:cl:
qol: Path of moon and lock now actually fit in the heretic tree
balance: Certain path of moon rituals that needed brains now use easier
to obtain organs
/:cl:

* [NO GBP] Fixes path of moon and path of lock sidepaths, replaces brains with other organs

---------

Co-authored-by: Rex9001 <[email protected]>
Co-authored-by: NovaBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants