[MIRROR] [CI Fix] The Demonic Frost-Miner will not attack corpses. #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DB IGNORE] (#24615) * [CI Fix] The Demonic Frost-Miner will not attack corpses. (#79294) ## About The Pull Request Fixes #79147. Prevents the Demonic Frost-Miner from shooting at corpses by returning early from `OpenFire()`. Also adds the "gutted" status effect to the corpses in its arena so it won't try to gut them. ## Why It's Good For The Game #78826 introduced an unfortunate bug by placing corpses in the Frost Miner's arena. There were a combination of three factors at play here: that the Miner attacks corpses, that it happens to use colossus bolts in its attacks, which dust corpses, and that some unfortunate quirk of life code causes runtimes if, as far as I can tell, a life tick goes off when a mob is at the wrong point in the dusting process. The time this process takes happened to perfectly coincide with the Monkey Business unit test (being the first test that takes a significant period of time), causing it to randomly fail. So, this fixes a flaky test that has been a pain in the ass for the last five days, is the big thing. Also, it can't possibly have been intended for the Miner to run around obliterating the aesthetic corpses in its arena within the first 15 seconds of any given round. Completely ruining the mood! I'll point out that this particular boss may have been forgotten in #77731, which set out to make only the colossus still gib/dust you, but even were that not the case I think it would be a bit silly for the Miner to be busy shooting lifeless corpses when a player shows up to challenge it, rather than standing in its scary ritual circle. ## Changelog :cl: fix: The Demonic Frost-Miner will no longer run around destroying the corpses in its arena the moment the round begins. /:cl: * [CI Fix] The Demonic Frost-Miner will not attack corpses. --------- Co-authored-by: lizardqueenlexi <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Oct 28, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 5, 2024
* [NO GBP] Fixes a minor bug in buildmode map export (#80761) ## About The Pull Request Simply put, if the value is null, respect the null value and return. ## Why It's Good For The Game Fixes the game from saying "[blank] is disabled" if you hit cancel or the x on the window  ## Changelog :cl: SomeRandomOwl fix: Build Mode Export's options menu now knows when you want to cancel and not change the options /:cl: * [NO GBP] Fixes a minor bug in buildmode map export --------- Co-authored-by: SomeRandomOwl <[email protected]> Co-authored-by: NovaBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24615
Original PR: tgstation/tgstation#79294
About The Pull Request
Fixes #79147.
Prevents the Demonic Frost-Miner from shooting at corpses by returning early from
OpenFire(). Also adds the "gutted" status effect to the corpses in its arena so it won't try to gut them.Why It's Good For The Game
#78826 introduced an unfortunate bug by placing corpses in the Frost Miner's arena. There were a combination of three factors at play here: that the Miner attacks corpses, that it happens to use colossus bolts in its attacks, which dust corpses, and that some unfortunate quirk of life code causes runtimes if, as far as I can tell, a life tick goes off when a mob is at the wrong point in the dusting process. The time this process takes happened to perfectly coincide with the Monkey Business unit test (being the first test that takes a significant period of time), causing it to randomly fail.
So, this fixes a flaky test that has been a pain in the ass for the last five days, is the big thing.
Also, it can't possibly have been intended for the Miner to run around obliterating the aesthetic corpses in its arena within the first 15 seconds of any given round. Completely ruining the mood!
I'll point out that this particular boss may have been forgotten in #77731, which set out to make only the colossus still gib/dust you, but even were that not the case I think it would be a bit silly for the Miner to be busy shooting lifeless corpses when a player shows up to challenge it, rather than standing in its scary ritual circle.
Changelog
🆑 lizardqueenlexi
fix: The Demonic Frost-Miner will no longer run around destroying the corpses in its arena the moment the round begins.
/:cl: