[MIRROR] Cuts the number of apply_damage copypaste procs from 3(.5) to 1, fixing a few bugs along the way
#323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to 1, fixing a few bugs along the way [MDB IGNORE] (#24619) * Cuts the number of `apply_damage` copypaste procs from 3(.5) to 1, fixing a few bugs along the way * Update _species.dm * Update damage_procs.dm * Modular adjustments * Update mutant_species.dm * Update mutant_species.dm --------- Co-authored-by: MrMelbert <[email protected]> Co-authored-by: Bloop <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Oct 28, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 11, 2024
* Chat color tweaks, v1 * Update chat_color.dm * Update chat_color.dm * Update chat_color.dm * Update chat_color.dm * Whoops * Whoops again! * Update chat_color.dm * Uhmm this doesn't include the # apparently * Just making this a bit neater and adding comments was it worth it? * Chat colors now go off your voice rather than name
Iajret
pushed a commit
that referenced
this pull request
Jan 11, 2024
* Chat color tweaks, v1 * Update chat_color.dm * Update chat_color.dm * Update chat_color.dm * Update chat_color.dm * Whoops * Whoops again! * Update chat_color.dm * Uhmm this doesn't include the # apparently * Just making this a bit neater and adding comments was it worth it? * Chat colors now go off your voice rather than name Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24619
Original PR: tgstation/tgstation#79207
About The Pull Request
apply_damageis now uniform, handled, in a single place. At the living level.brute_moddespite what documentation claims.check_species_weaknessproc on species.Why It's Good For The Game
The copy+paste of this proc made it awful, awful to maintain or add features to. And also made it very bug prone.
This just takes a step forward in making sustaining damage a lot more consistent, not only across all mobs, but across all methods of... taking damage. Unarmed attacks, hulk, item attacks, etc.
Changelog
🆑 Melbert
fix: People held at gunpoint can now flinch when being hit.
fix: Regenerating mobs no longer stop regenerating no matter hit with what.
fix: Pressure damage is now properly modified by a mob's brute damage modifier.
fix: Fixes some occasions which some effects (glass jaw, explodable worn items) won't respond to hits.
refactor: Refactored core code related to mobs sustaining damage.
/:cl: