Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Praetorian Modsuit #324

Merged
merged 3 commits into from
Oct 28, 2023
Merged

[MIRROR] Praetorian Modsuit #324

merged 3 commits into from
Oct 28, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

@Steals-The-PRs Steals-The-PRs commented Oct 27, 2023

Original PR: Skyrat-SS13/Skyrat-tg#24575

About The Pull Request

Adds in a new, unique modsuit for Blueshields, the Praetorian Modsuit.

It is stored inside of the Blueshield's locker, so that it can be obtained on every map, even if they do not have an office or a suit storage machine.

The PR also adds it to the list of items removed during cryo, in the rare event that a blueshield decides to go to sleep wearing their new modsuit.

It is fully sprited, both inventory and worn, in a slick black and blue color.

How This Contributes To The Skyrat Roleplay Experience

Blueshield, while a notable member of command staff as their protector, had the option of either a basic modsuit from robotics, or just a bag. I felt they deserved something befitting their role as a sort of honor guard for command.

This also allows them to, simply put, do their job of keeping command alive easier, while also standing apart from security due to the unique look. No one will mistake them for John Officer again!

Proof of Testing

This generally was a pretty easy thing to make. I had some minor compilation issues, as well as some confusion in how to attach the sprites to the suit itself.
At first, the suit was fully functional, but with no sprites. After some troubleshooting and figuring out where all of the pieces of code attached, I found out exactly where I needed to attach the sprites, largely using the contractor modsuit as an example. Armor values were also incorrect at first, but this was rectified, and confirmed on a test server.

I had no issues getting it to spawn in the lockers. That worked from the start.

I also edited the sprite halfway through, as originally the goal was to give them a larger blue pauldron, but in practice, it looked like crap. I am satisfied with where it currently stands, though once more people of different size and race start to wear it, I may update it once more.

Updated sprites shown below!

image

image

Changelog

🆑 Kyo, Iajret
balance: old FF bodyguard MODs now retired, all hail new Skyrat MOD! (bodyguard now available as reskin option for praetorian MOD)
add: Adds a new, unique modsuit for Blueshields - The Praetorian Modsuit!
add: Adds the Praetorian modsuit to blueshield lockers.
code: Added the Praetorian modsuit to list of items removed from cryo, in case a sleepy blueshield forgets to take off their suit.
/:cl:

* Adds a new unique modsuit for Blueshields,
stored inside of their locker.

* Update mod_types.dm

Cleaned up indentations.

* Update mod_types.dm

More indentation cleaning

* Update mod_types.dm

More indentation cleaning

* Update mod_types.dm

Indentation cleaning

* Update modsuit_armour.dm

Nerf of Bullet and Laser armor from 40 to 30, each.

* Update mod_theme.dm

Nerf of bullet and laser armor from 40 to 30, each.

* Delete modular_skyrat/modules/blueshield/code/modsuit/theme.dm

This file was obsolete, and is being removed to keep things clean.

* Praetorian Modsuit modularization changes

* Renamed file path for praetorian hardlight theme

* Delete code/modules/mod/mod_theme.dm

Code was added to new modular file as requested

* Update console_tgui.dm

Renamed file path from praetorian to blueshield

* Delete modular_skyrat/modules/modsuit_armour/modsuit_armour.dm

Code moved to modular file, deleted to clean bloat

* Praetorian Modsuit modularization changes

* Update mod_theme.dm

Moved code over to modular file

* Update mod_theme.dm

Moved code over to modular file

* Update modsuit_armour.dm

Code moved to it's own modular file

* Update modular_skyrat/modules/blueshield/code/modsuit/mod_theme.dm

makes it look proper

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Updated sprites, namely the helmet+visor and chest

* Secondary sprite fix on chest

---------

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
@Iajret Iajret added the Do Not Merge Какая-то хрень. Оно нам точно нужно? label Oct 27, 2023
@Iajret Iajret enabled auto-merge (squash) October 28, 2023 21:50
@Iajret Iajret merged commit 75a3199 into master Oct 28, 2023
AnywayFarus added a commit that referenced this pull request Oct 28, 2023
@Iajret Iajret deleted the upstream-mirror-24575 branch October 28, 2023 22:48
Iajret pushed a commit that referenced this pull request Jan 5, 2024
* Update mining_roles.dm

Removes erroneous Syndicate encryption key

* Update mining_roles.dm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code modification Do Not Merge Какая-то хрень. Оно нам точно нужно? Feature Sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants