[MIRROR] Adds support to the wet_floor component to avoid displaying its overlay, makes ice turfs no longer receive said wet overlay #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…its overlay, makes ice turfs no longer receive said wet overlay [MDB IGNORE] (#24628) * Adds support to the wet_floor component to avoid displaying its overlay, makes ice turfs no longer receive said wet overlay (#79275) ## About The Pull Request The title says it all, really. I always thought ice looked a bit silly, and always wondered why. Today, I found out it was because of the `wet_floor` component adding an overlay that suddenly made a turf that should look continuous, tiled, which in turn gave some very ugly visuals. Ice already looks slippery, you can tell that it's ice, and the overlay that was added to it just didn't really help telegraph that any better than the sprite itself already does. That's why I added support to make it so it would be possible to force the overlay to just not be applied to the turf that's affected by the component, to make it all look a bit better overall. I added it to the ice turfs as a proof of concept, although I guess it could also be used on other turfs that are always "wet", like the bananium floors, but I didn't really care enough to touch that yet, and I guess the bananium floors can use it a bit better than ice did. I did notice in this PR that the smoothing of ice seemed to potentially be broken, but that's something to look into at a later time. ## Why It's Good For The Game Look at this ice and how much smoother it looks like now:  ## Changelog :cl: GoldenAlpharex code: Added support to the wet_floor component to make it so the wet overlay could not be applied to certain turfs if desired. fix: Ice turfs no longer look tiled, and instead look smooth when placed next to one-another. /:cl: * Adds support to the wet_floor component to avoid displaying its overlay, makes ice turfs no longer receive said wet overlay --------- Co-authored-by: GoldenAlpharex <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Oct 28, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 6, 2024
* Hotfixing * Oopsie daisy * Should be good now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24628
Original PR: tgstation/tgstation#79275
About The Pull Request
The title says it all, really.
I always thought ice looked a bit silly, and always wondered why. Today, I found out it was because of the
wet_floorcomponent adding an overlay that suddenly made a turf that should look continuous, tiled, which in turn gave some very ugly visuals. Ice already looks slippery, you can tell that it's ice, and the overlay that was added to it just didn't really help telegraph that any better than the sprite itself already does.That's why I added support to make it so it would be possible to force the overlay to just not be applied to the turf that's affected by the component, to make it all look a bit better overall.
I added it to the ice turfs as a proof of concept, although I guess it could also be used on other turfs that are always "wet", like the bananium floors, but I didn't really care enough to touch that yet, and I guess the bananium floors can use it a bit better than ice did.
I did notice in this PR that the smoothing of ice seemed to potentially be broken, but that's something to look into at a later time.
Why It's Good For The Game
Look at this ice and how much smoother it looks like now:
Changelog
🆑 GoldenAlpharex
code: Added support to the wet_floor component to make it so the wet overlay could not be applied to certain turfs if desired.
fix: Ice turfs no longer look tiled, and instead look smooth when placed next to one-another.
/:cl: