Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Praetorian Modsuit Digitigrade sprite fix #331

Merged
merged 2 commits into from
Oct 28, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: Skyrat-SS13/Skyrat-tg#24629

About The Pull Request

Made the Praetorian Modsuit compatibile with digitigrade character sprites, because turns out I forgot about them

Also includes a minor code edit to make sure the sprites are properly loaded. Both human and digitigrade leg characters have been tested and are working properly now!

How This Contributes To The Skyrat Roleplay Experience

This is necessary for the praetorian modsuit recently merged to show on digitigrade sprites.

Proof of Testing

Tested on both human and digitigrade legged sprites, screenshot included. They work fine now!
image

Changelog

🆑 Kyo
fix: Digitigrade sprites for Praetorian modsuit will now work as intended.
/:cl:

* Adds a new unique modsuit for Blueshields,
stored inside of their locker.

* Update mod_types.dm

Cleaned up indentations.

* Update mod_types.dm

More indentation cleaning

* Update mod_types.dm

More indentation cleaning

* Update mod_types.dm

Indentation cleaning

* Update modsuit_armour.dm

Nerf of Bullet and Laser armor from 40 to 30, each.

* Update mod_theme.dm

Nerf of bullet and laser armor from 40 to 30, each.

* Delete modular_skyrat/modules/blueshield/code/modsuit/theme.dm

This file was obsolete, and is being removed to keep things clean.

* Praetorian Modsuit modularization changes

* Renamed file path for praetorian hardlight theme

* Delete code/modules/mod/mod_theme.dm

Code was added to new modular file as requested

* Update console_tgui.dm

Renamed file path from praetorian to blueshield

* Delete modular_skyrat/modules/modsuit_armour/modsuit_armour.dm

Code moved to modular file, deleted to clean bloat

* Praetorian Modsuit modularization changes

* Update mod_theme.dm

Moved code over to modular file

* Update mod_theme.dm

Moved code over to modular file

* Update modsuit_armour.dm

Code moved to it's own modular file

* Update modular_skyrat/modules/blueshield/code/modsuit/mod_theme.dm

makes it look proper

Co-authored-by: GoldenAlpharex <[email protected]>

* Updated sprites, namely the helmet+visor and chest

* Secondary sprite fix on chest

* Praetorian modsuit - digitigrade sprite fix

* fixed missing sprite in mod.dmi

---------

Co-authored-by: GoldenAlpharex <[email protected]>
@Steals-The-PRs Steals-The-PRs added Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота Skyrat Mirror Fix labels Oct 28, 2023
@Iajret Iajret enabled auto-merge (squash) October 28, 2023 22:47
@Iajret Iajret merged commit 10d42c9 into master Oct 28, 2023
22 checks passed
AnywayFarus added a commit that referenced this pull request Oct 28, 2023
@Iajret Iajret deleted the upstream-mirror-24629 branch October 28, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота Sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants