[MIRROR] Your unarmed attacks are once again blocked even when you're not in combat mode #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not in combat mode [MDB IGNORE] (#24631) * Your unarmed attacks are once again blocked even when you're not in combat mode (#79233) ## About The Pull Request Currently, not being in combat mode when making an unarmed attack allows you to bypass ALL BLOCKING. All of it. Every single kind of shielding. This is now fixed. As a consequence, hugging is now blocked, but that's fine, hugging puts you into click cooldown and _might actually be an attack now_. [Like the Hugs of the Gondola martial art](https://github.com/tgstation/tgstation/blob/ab058330b4449f133b7672565c91d28af8ed7e05/code/datums/martial/hugs_of_the_gondola.dm) Fixes tgstation/tgstation#72812 ## Why It's Good For The Game This was broken with COMBAT MODE AAAAAAAAAAAH ### AAAAAAAAAAAH ## Changelog :cl: fix: Every person on the station now no longer has the Tranquility Evades the Shield Pinky Finger Shovegrab unarmed combat technique, an ancient and forbidden strike that allows anyone (literally anyone) to bypass all forms of blocking defense by simply not being in combat mode when they shove or grab their target. As a direct result, the chakra energy of the Spinward Sector has become severely misaligned. Oh well. /:cl: * Your unarmed attacks are once again blocked even when you're not in combat mode --------- Co-authored-by: necromanceranne <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Oct 29, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 6, 2024
fix tgs version feedbackdb logging (#80774) I found this while looking in this file for other reasons. Shutdown is called after blackbox.Seal() in 99% of cases, keeping this from getting logged. Co-authored-by: Kyle Spier-Swenson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24631
Original PR: tgstation/tgstation#79233
About The Pull Request
Currently, not being in combat mode when making an unarmed attack allows you to bypass ALL BLOCKING. All of it. Every single kind of shielding.
This is now fixed.
As a consequence, hugging is now blocked, but that's fine, hugging puts you into click cooldown and might actually be an attack now. Like the Hugs of the Gondola martial art
Fixes tgstation/tgstation#72812
Why It's Good For The Game
This was broken with COMBAT MODE AAAAAAAAAAAH
AAAAAAAAAAAH
Changelog
🆑 necromanceranne
fix: Every person on the station now no longer has the Tranquility Evades the Shield Pinky Finger Shovegrab unarmed combat technique, an ancient and forbidden strike that allows anyone (literally anyone) to bypass all forms of blocking defense by simply not being in combat mode when they shove or grab their target. As a direct result, the chakra energy of the Spinward Sector has become severely misaligned. Oh well.
/:cl: