[MIRROR] Wearing Hailer gives unique death SFX #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Wearing Hailer gives unique death SFX (#79216) ## About The Pull Request If you die with a SecHailer on, a unique sound effect will play (created entirely by me using in-game files): https://github.com/tgstation/tgstation/assets/42353186/042e4159-57f3-4cc1-8d96-4dc7289f194b (Please note that the pitch is randomized) You can give any mask's unique death sound effects now. ## Why It's Good For The Game SecHailers can change people's voices. Why not make them sound different when they die? It could be a humorous reference with a unique sound. SecHailers' voice changer function is a reference, which I expanded by also making a unique death sound effect. Also now you can make more masks with unique death sound effects if you want to. ## Changelog :cl: sound: Dying with a SecHailer on your face will make a unique death sound /:cl: --------- Co-authored-by: MrMelbert <51863163+MrMelbert@ users.noreply.github.com> Co-authored-by: Ghom <42542238+Ghommie@ users.noreply.github.com> * Wearing Hailer gives unique death SFX --------- Co-authored-by: DrTuxedo <[email protected]> Co-authored-by: MrMelbert <51863163+MrMelbert@ users.noreply.github.com> Co-authored-by: Ghom <42542238+Ghommie@ users.noreply.github.com>
AnywayFarus
added a commit
that referenced
this pull request
Oct 29, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 6, 2024
… (#80787) (#335) conveyors stop conveying whatever exits their z level (#80787) ## About The Pull Request not fixed https://github.com/tgstation/tgstation/assets/70376633/a6269a2f-abaf-48af-98de-561f7b1db8e6 fixed https://github.com/tgstation/tgstation/assets/70376633/f77fe38d-aa3f-468a-a4fd-95a2dfca0a1f ## Why It's Good For The Game fixes #80575 ## Changelog :cl: fix: conveyor belts no longer maintain movement if whatever is on them suddenly leaves their z level /:cl: Co-authored-by: jimmyl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24634
Original PR: tgstation/tgstation#79216
About The Pull Request
If you die with a SecHailer on, a unique sound effect will play (created entirely by me using in-game files):
Seccie.Metrocop.Flatline.mp4
(Please note that the pitch is randomized)
You can give any mask's unique death sound effects now.
Why It's Good For The Game
SecHailers can change people's voices. Why not make them sound different when they die? It could be a humorous reference with a unique sound.
SecHailers' voice changer function is a reference, which I expanded by also making a unique death sound effect.
Also now you can make more masks with unique death sound effects if you want to.
Changelog
🆑 DrDiasyl
sound: Dying with a SecHailer on your face will make a unique death sound
/:cl: