[MIRROR] Improved nightshift check on security level change #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RE] (#24695) * Improved nightshift check on security level change (#79369) ## About The Pull Request Modifies the security level change proc to only fire the nightshift subsystem if the subsystem is running, and if a lighting change is required. If a lighting change is required, nightshift has its next fire set 7 seconds after, so announcements and sounds don't stack. ## Why It's Good For The Game Nightshift is only updated when required, eliminating nuisance announcements when levels unrelated to red/delta are selected. ## Changelog :cl: LT3 code: Changing security levels will only trigger the nightshift subsystem if lighting changes are required /:cl: * Improved nightshift check on security level change --------- Co-authored-by: lessthanthree <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24695
Original PR: tgstation/tgstation#79369
About The Pull Request
Modifies the security level change proc to only fire the nightshift subsystem if the subsystem is running, and if a lighting change is required. If a lighting change is required, nightshift has its next fire set 7 seconds after, so announcements and sounds don't stack.
Why It's Good For The Game
Nightshift is only updated when required, eliminating nuisance announcements when levels unrelated to red/delta are selected.
Changelog
🆑 LT3
code: Changing security levels will only trigger the nightshift subsystem if lighting changes are required
/:cl: