[MIRROR] Removes virtual-specific megafauna, fixes boss map issues #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…O GBP] [MDB IGNORE] (#24737) * Removes virtual-specific megafauna, fixes boss map issues [NO GBP] (#79424) ## About The Pull Request Another atomization of the content patch- Let's not subtype everything into virtual variants This also fixes some bugs that were present with vdom boss maps - Made the bubblegum map larger so he wouldn't teleport out - Legion is just far too annoying to have to fix code wise, given that few if anyone tries it with the base virtual equipment <details> <summary>what do you mean too annoying?</summary> Legion doesn't handle dying like the standard megafauna - each time it "dies" it looks to see if there's another legion in the entire game world. Given the real one very likely exists, this basically means it won't drop anything. I'd have to modify legion's death proc specifically for the virtual domain. No other megafauna has this level of weirdness (nor splitting behavior) and coupled with the fact I think no one tries the domain, I'm just removing it. </details> ## Why It's Good For The Game Cleans up megafauna subtypes that were specific for the virtual domain. Now, we won't need to keep adding to the list if there's ever a new one Fixes #79203 Fixes #79200 ## Changelog :cl: fix: Bubblegum should no longer teleport out of the simulation when threatened del: Chamber of Echoes map removed as it conflicts with the actual Legion /:cl: * Removes virtual-specific megafauna, fixes boss map issues [NO GBP] --------- Co-authored-by: Jeremiah <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 3, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 11, 2024
* Fix supermatter component runtime on non-supermatters (#80894) ## About The Pull Request Used the wrong var for this istype check. * Fix supermatter component runtime on non-supermatters --------- Co-authored-by: MrMelbert <[email protected]> Co-authored-by: NovaBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24737
Original PR: tgstation/tgstation#79424
About The Pull Request
Another atomization of the content patch-
Let's not subtype everything into virtual variants
This also fixes some bugs that were present with vdom boss maps
what do you mean too annoying?
Legion doesn't handle dying like the standard megafauna - each time it "dies" it looks to see if there's another legion in the entire game world. Given the real one very likely exists, this basically means it won't drop anything. I'd have to modify legion's death proc specifically for the virtual domain. No other megafauna has this level of weirdness (nor splitting behavior) and coupled with the fact I think no one tries the domain, I'm just removing it.
Why It's Good For The Game
Cleans up megafauna subtypes that were specific for the virtual domain. Now, we won't need to keep adding to the list if there's ever a new one
Fixes #79203
Fixes #79200
Changelog
🆑 jlsnow301
fix: Bubblegum should no longer teleport out of the simulation when threatened
del: Chamber of Echoes map removed as it conflicts with the actual Legion
/:cl: