[MIRROR] Reverts reverted toast icons #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reverts reverted toast icons (#79538) ## About The Pull Request During the notify ghosts refactor I was unsure why we were creating a custom overlay for each ghost alert when new_master did the same. Turns out - it resets icons, which is useful here. This also caused #79415. The original notify ghosts was performing this transformation operation O(n), which I've made O(1) ## Why It's Good For The Game Fixes #79415  ## Changelog :cl: fix: The screen alert should no longer break ghost UI when it's huge /:cl: --------- Co-authored-by: Ghom <42542238+Ghommie@ users.noreply.github.com> * Reverts reverted toast icons --------- Co-authored-by: Jeremiah <[email protected]> Co-authored-by: Ghom <42542238+Ghommie@ users.noreply.github.com>
AnywayFarus
added a commit
that referenced
this pull request
Nov 7, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 17, 2024
* Removes timeout_mod arg from add_mood_effect * Fix conflicts --------- Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24844
Original PR: tgstation/tgstation#79538
About The Pull Request
During the notify ghosts refactor I was unsure why we were creating a custom overlay for each ghost alert when new_master did the same. Turns out - it resets icons, which is useful here. This also caused #79415.
The original notify ghosts was performing this transformation operation O(n), which I've made O(1)
Why It's Good For The Game
Fixes #79415
Changelog
🆑 jlsnow301
fix: The screen alert should no longer break ghost UI when it's huge
/:cl: