Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Surgery speed rebalance and changes #5154

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#4563

About The Pull Request

Removes Nova's (or rather, the older server's) old analgesic speed bonus in favor of TG's (NovaSector/NovaSector#957) and turns the speedup modifier into a calm environment modifier, also reducing it's speed bonus from 50% down to 20%

Calm environment modifier itself is mostly left untouched aside from some wording changes in the code and making it a bit more clear to what it is.

Videos of how this impacts surgery speed are in proof of testing.

How This Contributes To The Nova Sector Roleplay Experience

Currently, surgeries are so fast that they nearly match alien tools with really little effort. This is mostly a result of our modular speedup bonus being faster than even TG's surgery speed modifiers, as well as Nova's and TG's analgesics bonus co-existing which results into them stacking into a boost of 70%.

For reference; Miner's salve boosts surgery speed by 10%, TG's analgesia, dissection and sterilizine all boost the surgery speed by 20% and can all be stacked together while our modular speedup just boosts it up to 50% with very little effort just by being in an empty room and easily can be stacked into 100% (120% with TG analgesia modifier) speed boost if you drug your patient with painkillers or have them in a stasis bed (which would then be reduced down to 110% due to it having a debuff of 10%).

Medical players are meant to be awarded for the effort they spend into getting their patient prepared for surgery rather than a flat 50% speed bonus with very little effort, this should also discourage doctors from doing basic surgeries on a stasis bed.

Proof of Testing

Screenshots/Videos All of these are organ manipulation surgeries followed with cauterizing No bonus
dreamseeker_hvgewZxRrh.mp4

Calm environment bonus

dreamseeker_yqNDk8APWf.mp4

Numb and calm environment bonus

dreamseeker_CLtjukhbTg.mp4

Changelog

🆑 Hardly
balance: Removes the 50% speedup surgery speed bonus from being in a calm environments and numb/dead patients
balance: Calm environment instead now boosts surgery speed by 20%
remove: Removed Nova's modular numb surgery speed boost due to it conflicting with TG's
/:cl:

Hardly3D and others added 2 commits November 6, 2024 06:12
* Update surgery_step.dm

* :3

* Update code/modules/surgery/surgery_step.dm

---------

Co-authored-by: Bloop <[email protected]>
@FeenieRU FeenieRU merged commit 80318af into master Nov 6, 2024
31 of 33 checks passed
AnywayFarus added a commit that referenced this pull request Nov 6, 2024
@Iajret Iajret deleted the upstream-mirror-4563 branch December 21, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants