Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIRROR] [MODULAR] Adds mag-fed turret limitations to pneumatic cannon #5198

Merged
merged 2 commits into from
Nov 26, 2024
Merged

[MIRROR] [MODULAR] Adds mag-fed turret limitations to pneumatic cannon #5198

merged 2 commits into from
Nov 26, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#4596

About The Pull Request

Pneumatic cannon now has unique interactions with mag-fed turret kits:

  • Only one can fit into the pneumatic cannon
  • You cannot load a turret into a pneumatic item with any other objects and vice versa

How This Contributes To The Nova Sector Roleplay Experience

Loading more than one turret into a pneumatic cannon isn't good for balance, for several reasons:

  1. While they can be/are sized small enough to be stored in backpacks easily, Having a tool dedicated to mass-distributing turrets should be separately designed with balance in mind. Such an idea would also have to pass a desire outside of the deathmatch minigame for serious consideration
  2. Loading large amounts of turrets into the cannon creates a storage dilemma: They're designed as tools in addition or as a dedicated gimmick leaving little space left or taking key equipment slots. Having more than 5 rapidly deployed (again, outside of a dedicated tool) breaks balance in space economy
  3. Finally, It basically becomes an easy way to line 1x1 hallways with layers of blockades that can EASILY (ok maybe not easily if you also have a gun and just start blasting, as per our lord, Dani Dorito) take you out without preparations, annoying (often) security as they can become trapped in the right circumstances. Its good this was caught before easier ways to get lethal turrets were put in, let alone in this level of ease of deployment.

Proof of Testing

Screenshots/Videos
2024-11-14.11-49-27.mp4

(note: i did decide that, "Hey, We're not just loading from the barrel, Why else does the pneumatic cannon have this second long tube?" and did some edits post-capture)

Changelog

🆑 Zenitheevee
balance: Pneumatic cannons can now hold only one turret kit if loaded with one.
/:cl:

Zenitheevee and others added 2 commits November 25, 2024 06:36
@Zenitheevee @vinylspiders
[MODULAR] Adds mag-fed turret limitations to pneumatic cannon (#4596)
1190451 
* FIRST TRY LETS GO - adds limits to pneumatic cannon

* Update code/game/objects/items/pneumaticCannon.dm

* Modularization Edit

* make it parent-code friendly:tm:

* comment readability

* Update modular_nova/master_files/code/game/objects/items/pneumaticCannon.dm

---------

Co-authored-by: Bloop <[email protected]>
[MIRROR] [MODULAR] Adds mag-fed turret limitations to pneumatic cannon
8858ec8
@FeenieRU FeenieRU merged commit 6ebe8bb into master Nov 26, 2024
32 checks passed
AnywayFarus added a commit that referenced this pull request Nov 26, 2024
@AnywayFarus
Automatic changelog for PR #5198 [ci skip]
a0772f5
@Iajret Iajret deleted the upstream-mirror-4596 branch December 21, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Balance Nova Mirror
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Steals-The-PRs @FeenieRU @Zenitheevee