[MIRROR] [MODULAR] Brings emissive barsigns to skyrat, reorganizes our modular files #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… files (#24842) * Better modularized barsigns * Update barsigns.dmi * Update barsigns.dm * Update barsigns.dm * Convert to 64x32 * Update barsigns96x96.dmi * Update barsigns.dm * Update barsigns.dmi * Found the missing D on the meadbay sign * meadbay sign again * Fix the unit test * More light masks + removes duplicate empty and emp sprites * More light masks * Tardis light mask, some fixes for stray pixels * Cleaned up some pixels * A few more light masks * Update barsigns.dm * Update barsigns.dm
AnywayFarus
added a commit
that referenced
this pull request
Nov 9, 2023
Iajret
pushed a commit
that referenced
this pull request
Mar 30, 2024
* Add echolocation quirk w/ customizable echo overlay, and echo types * Make sure echolocation can't be taken with similar quirks * Actually use the right path * Static type and reorder dme * Remove some leftover test comments * Modularization improvements Co-authored-by: Bloop <[email protected]> * Further modularization and dejankify client_colour handling * Clean up client_colours in remove() * Add stall/toggle power to echolocation quirk holders --------- Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: Skyrat-SS13/Skyrat-tg#24842
About The Pull Request
They were always there, we just had modular overriding them.
Modular barsigns were implemented..interestingly. All the 64x32 TG sprites were copy pasted into a 96x96 sprite modular file and this was overridden as the icon file to use for all barsigns.
The file was not up to date with the emissive light masks, so the TG sprites weren't getting any of those. Furthermore, there was only one single 96x96 sprite in there, and it wasn't even useable in-game.
This PR splits the skyrat barsigns into
datum/barsign/skyrat, and gets rid of all the duplicated out of date tg sprites that were inmodular_skyrat/modules/barsigns/icons/barsigns.dmi. There is now a separate file for 96x96 sprites and the rest of them have been painstakingly converted back to 64x32.It also adds support for large barsigns, and adds the cyberslyph barsign as useable option. I created the lightmask for that sprite, but I did not create them for all of the Skyrat signs. It's a lot of work, and is definitely something that anyone else can take up if they'd like to! I did a few of them, however, shown below.
How This Contributes To The Skyrat Roleplay Experience
Shaves off some extra bandwidth and removes needlessly duplicated sprites. Brings emissive barsigns to skyrat, which was a feature we'd been missing out on. Makes our system more modular.
Proof of Testing
The large barsign admittedly doesn't look great unless you have the right wall and space for it (it can clip through things and get cut off easily), but it's there as an option for people who don't mind doing a bit of extra work to make it look nice.
TG emissives
A few Skyrat emissives
Changelog
🆑 vinylspiders
fix: the TG barsigns will now use emissives (aka, they will glow in the dark)
fix: skyrat signs will give off small amounts of neon colored neon light like TG signs do
image: cyberslyph barsign (the only 96x96 sign) is now useable in the game, and uses emissives.
image: added some emissive light masks for a few of the skyrat barsigns
refactor: converted the modular barsigns file to 64x32, and added a separate file for 96x96 signs along with modular support for large signs
/:cl: