Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes a bug with hash grinding #5270

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#4716

About The Pull Request

So it came to my attention that hash creation does not work currently. You are supposed to be able to grind dried cannabis leaves using a mortar and pestle or reagent grinder but it fails to do so due to a bug.

The original code was trying to do some hackish stuff that no longer works with all the subsequent changes to grinding post-foodening. This PR just restores the ability to make this.

Some notes: You can still make hash from grinding dried mutated strains but it gets to be a bit silly with all the extra reagents that you get in your beaker or mortar. That cannot really be helped short of changing the way hash gets created but I do not really see it as an issue so much as just how produce grinding works. Another note: rainbow cannabis contains no thc so thus does not yield any hash when ground.

How This Contributes To The Nova Sector Roleplay Experience

Proof of Testing

Screenshots/Videos

Foxboi druglab...

image

dreamseeker_NzuR0b8E6Q

dreamseeker_vHVzMhhipJ

Changelog

🆑 vinylspiders
fix: hash can now be created again by grinding dried cannabis leaves in a grinder or with a mortar and pestle
/:cl:

Copy link
Contributor

github-actions bot commented Jan 8, 2025

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale label Jan 8, 2025
@FeenieRU FeenieRU merged commit a9016d1 into master Jan 8, 2025
32 of 33 checks passed
AnywayFarus added a commit that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants