Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] [Early Mirror]Adds a .NET 9 SDK setup action to linters (#88988) #5284

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#4742

About The Pull Request

Early Mirror of tgstation/tgstation#88988

OpenDream was recently bumped to .NET 9, which is not on our runner image. I added an action which installs the required .NET version for DMCompiler to function.

Why It's Good

Adding this action is not only good as a quick hack fix, but also for posterity.
I also considered the impact this has on our runner execution time, but my hope is that it should not matter if we have .NET installed already.

About The Pull Request

How This Contributes To The Nova Sector Roleplay Experience

Proof of Testing

Screenshots/Videos

Changelog

🆑 OrbisAnima
code: Hopefully fixes opendream issues
/:cl:

OrbisAnima and others added 2 commits January 9, 2025 23:51
Adds a .NET 9 SDK setup action to linters (#88988)

## About The Pull Request

OpenDream was recently bumped to .NET 9, which is not on our runner
image. I added an action which installs the required .NET version for
DMCompiler to function.

## Why It's Good

Adding this action is not only good as a quick hack fix, but also for
posterity.
I also considered the impact this has on our runner execution time, but
my hope is that it should not matter if we have .NET installed already.

Co-authored-by: Ivory <[email protected]>
@Iajret Iajret merged commit cca6988 into master Jan 10, 2025
33 checks passed
@Iajret Iajret deleted the upstream-mirror-4742 branch January 10, 2025 19:37
AnywayFarus added a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants