Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] NRI Police Outfit Redesign #529

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: Skyrat-SS13/Skyrat-tg#24433

About The Pull Request

Starting with the less important stuff, the old NRI police uniform is now gone, getting rid of another Flavrius sprite that didn't fit with the entirety of the codebase.
"NRI ERT" module has been renamed into, simply "NRI" module to better reflect its purpose, as it's no longer used by the NRI ERT only (Which I'll probably remove at a later date). No longer true.
Now for the cool part: NRI Inspectors midround as well as the company imports have been given an entirely new outfit shamelessly copied from Disco Elysium's Revachol Citizens'/Citizen's Militia, -just like the colonial outfit-. Said outfits are, obviously, worn by the NRI police midround, among the new NRI Police armor set that's currently replacing that ancient as hell terribly green Z army Ratnik armor set, same for the NRI police gas mask.
image
image
image
image

How This Contributes To The Skyrat Roleplay Experience

For the "boring" part: NRI module now actually represents what it does; unfitting sprites suck. Ditto.
For the more interesting part:
Well, really though, unfitting sprites suck, since the previous NRI police uniform was overly militaristic. Ideally, this new outfit should make them feel themselves less aggressive and less looking like weirdly shaded mess and better represents their purpose as diplomats and inspectors instead of an actual combat personnel.

Proof of Testing

Screenshots/Videos

image
image
image
image
image

Changelog

🆑 Stalkeros, Zydras for the sprites
add: NRI Police outfit full redesign. Sunrise, Parabellum.
imageadd: NRI Police MODsuit palette swapped.
/:cl:

* fucking finally

* defines unneeded

* CI fix

* This sure took a while

* oh god i forgot to pr this

* Apply suggestions from code review

Co-authored-by: Bloop <[email protected]>

* done

* Apply suggestions from code review

Co-authored-by: GoldenAlpharex <[email protected]>

* Missed this one.

Co-authored-by: GoldenAlpharex <[email protected]>

* This should do.

* Update readme.md

* Sucks!

* I Love Merge Conflicts!

* Sad I guess

* Map conflict fixed

* Update mod.dmi

* normal sized taser

---------

Co-authored-by: Bloop <[email protected]>
Co-authored-by: GoldenAlpharex <[email protected]>
@Iajret Iajret merged commit c48b6e0 into master Nov 9, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-24433 branch November 9, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants