[MIRROR] Cuts down on unnecessary non-TGUI stuff #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cuts down on unnecessary non-TGUI stuff (#79590) ## About The Pull Request Removes INTERACT_MACHINE_SET_MACHINE on machines that don't use a non-TGUI UI. Removes set_machine from TGUI things that forgot to remove them previously. Decouples advanced camera consoles from UI procs since it doesn't actually use one. ## Why It's Good For The Game TGUI machines don't need to be using these procs and vars, and this makes it more clear what does and doesn't use a TGUI menu from a glance. I explain it a bit better [here](https://hackmd.io/XLt5MoRvRxuhFbwtk4VAUA) if you're interested. ## Changelog No player-facing changes. * Cuts down on unnecessary non-TGUI stuff --------- Co-authored-by: John Willard <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Jan 21, 2024
…cies/limbs (#539) * Fix arm implant hotkeys no longer working after changing species/limbs (#81020) ## About The Pull Request Currently, if your arm gets changed for any reason (through surgery or by changing species), it breaks the Z hotkey for activating the toolset implant in said arm until you take the implant out and put it back in. This fixes that. Somewhat of a port of BeeStation/BeeStation-Hornet#9167 ## Why It's Good For The Game This is clearly unintended behavior, which is bad, bugs are bad. ## Testing Evidence. https://github.com/tgstation/tgstation/assets/65794972/b5e1e690-ef11-4db6-81ab-85571f83d178 ## Changelog :cl: fix: Tool arm implant hotkeys will properly work even after you change your arm/species now. /:cl: * Fix arm implant hotkeys no longer working after changing species/limbs --------- Co-authored-by: Lucy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24896
Original PR: tgstation/tgstation#79590
About The Pull Request
Removes INTERACT_MACHINE_SET_MACHINE on machines that don't use a non-TGUI UI.
Removes set_machine from TGUI things that forgot to remove them previously.
Decouples advanced camera consoles from UI procs since it doesn't actually use one.
Why It's Good For The Game
TGUI machines don't need to be using these procs and vars, and this makes it more clear what does and doesn't use a TGUI menu from a glance.
I explain it a bit better here if you're interested.
Changelog
No player-facing changes.