Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Add CI mapping linter to check for duplicate windows on same tile #559

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24916
Original PR: tgstation/tgstation#79487

About The Pull Request

Waiting for the following PR to get merged:

  • #79394

This adds a simple map linter to check for duplicate windows in the same tile. It also removes existing duplicates from:

  • Birdshot Station
  • Delta Station
  • Anomaly Research Ruin

Why It's Good For The Game

Better mapping consistency.

Changelog

🆑 timothymtorres
del: Remove duplicate windows from birdshot, delta, and anomaly research ruin.
/:cl:

… tile [MDB IGNORE] (#24916)

* Add CI mapping linter to check for duplicate windows on same tile (#79487)

This adds a simple map linter to check for duplicate windows in the same
tile. It also removes existing duplicates from:
- Birdshot Station
- Delta Station
- Anomaly Research Ruin

* Add CI mapping linter to check for duplicate windows on same tile

* Update lavaland_surface_syndicate_base1_skyrat.dmm

* Fixes so much blueshift window jank

* But wait there's more

* Update Blueshift.dmm

---------

Co-authored-by: Tim <[email protected]>
Co-authored-by: Giz <[email protected]>
@Iajret Iajret merged commit 8e514fb into master Nov 11, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-24916 branch November 11, 2023 13:24
AnywayFarus added a commit that referenced this pull request Nov 11, 2023
Iajret pushed a commit that referenced this pull request Jan 22, 2024
* Fixing goldgrubs barfing what they shouldn't. (#81042)

## About The Pull Request
See #81041.

## Why It's Good For The Game
Fix #81041

## Changelog

:cl:
fix: Goldgrubs should no longer spit out things that aren't ore (e.g.
stasised mobs from the polymorph belt).
/:cl:

* Fixing goldgrubs barfing what they shouldn't.

---------

Co-authored-by: Ghom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants