Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Admin opfor panel permission flag tweak. #577

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: Skyrat-SS13/Skyrat-tg#24892

About The Pull Request

This PR changes flag that is nessecery to use admin opfor panel.

  • Old flag: R_AUTOADMIN
  • New flag: R_ADMIN

How This Contributes To The Skyrat Roleplay Experience

This will make life easier for staff, especially for downstream staff, where they have different admin ranks.

Proof of Testing

There is nothing to test.

Changelog

🆑 SSensum
admin: Admin opfor panel now requires a R_ADMIN flag instead of R_AUTOADMIN flag.
/:cl:

@Iajret Iajret merged commit d6b76a8 into master Nov 12, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-24892 branch November 12, 2023 20:49
AnywayFarus added a commit that referenced this pull request Nov 12, 2023
Iajret pushed a commit that referenced this pull request Jan 23, 2024
* Fixes a spurious CI runtime in do_charge() (#81048)

## About The Pull Request

Fixes this runtime here


![firefox_ukNfWhCyF1](https://github.com/tgstation/tgstation/assets/13398309/460157ed-2c18-44c0-9339-49da6fc605d0)

These signals can evidently be overridden and some of these were missing
the override = TRUE parameter.

## Why It's Good For The Game

Less CI fails

## Changelog

:cl:
fix: fixes a spurious CI failure from do_charge() signal overrides
/:cl:

* Fixes a spurious CI runtime in do_charge()

---------

Co-authored-by: Bloop <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants