[MIRROR] [NO GBP} Makes it so that punch miss chance can actually go above 20% #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…above 20% [MDB IGNORE] (#24940) [NO GBP} Makes it so that punch miss chance can actually go above 20% Co-authored-by: necromanceranne <[email protected]> Co-authored-by: Giz <[email protected]>
Steals-The-PRs
added
Mirroring conflict
AnywayFarus
added a commit
that referenced
this pull request
Nov 14, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 23, 2024
* Fixes ejecting pAIs card without a pAI in it (#81047) ## About The Pull Request I had made the bad assumption that a pAI card always had a pAI mob in it, which is not the case. This fixes the runtime error, thus allowing people to eject a pAI card that doesn't have a pAI in it. I've also added a check in the pAI's Initialize to give them the ability to use the modPC if they are made in it, so you don't have to eject and reinsert the pAI, fixing another issue. ## Why It's Good For The Game Closes tgstation/tgstation#81043 Fixes inconsistency and runtime. ## Changelog :cl: fix: pAIs downloaded while in a PDA now gets the action button to control said PDA. fix: pAI cards can now be ejected from a PDA when there is no pAI inhabiting it. /:cl: * Fixes ejecting pAIs card without a pAI in it --------- Co-authored-by: John Willard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24940
Original PR: tgstation/tgstation#79611
About The Pull Request
The max potential miss chance is 80%, rather than 20%. (Yes, I know I put it to 75% in the pr but actually I wanted an even number and my fucking adhd brain forgot that this was meant to be changed)
Why It's Good For The Game
I only got shown this was wrong literally the moment after my pr got merged AAAAAH
Helpies!
Changelog
🆑 necromanceranne
fix: The Dread Disciples of Maint Khan, notorious Tunnel Arts practitioner and maintenance warlord, have been driven from Nanotrasen stations within the Spinward Sector. The average punch accuracy has been increased as a direct result, with the most exhausted puncher now having a max potential inaccuracy of 80%, rather than the absurd 20% of the Disciples.
/:cl: