Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes Ashwalker Tendril Revives #581

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24945
Original PR: tgstation/tgstation#79637

About The Pull Request

  • Changes the Ashwalker Tendril revive proc to hold the old body until the revive is done, and only delete the old body after moving the mind/client over.
  • Changes a single-letter var name to be more proper.

Why It's Good For The Game

Fixes #79635

The issue seems to have been due to the old mob being deleted, which deleted the mind. Later, when the new body was created, the mind was unavailable due to being deleted. So now, we just hold the old body for a bit and delete it once the new body is finished.

I'm not sure why this suddenly stopped working. Perhaps we were abusing a long hard-del that delayed the mind being deleted and now it's no longer a thing?

Changelog

🆑 zxaber
fix: Ashwalker Tendril Revives no longer ghost the player being revived.
/:cl:

* Fixes Ashwalker Tendril Revives

* Update ash_walker_den.dm

---------

Co-authored-by: zxaber <[email protected]>
Co-authored-by: Giz <[email protected]>
@Iajret Iajret merged commit 476f4a6 into master Nov 12, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-24945 branch November 12, 2023 20:52
AnywayFarus added a commit that referenced this pull request Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants