[MIRROR] Fixes the EMP Barsign sprite not displaying #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4951) * Fixes the EMP Barsign sprite not displaying (#79599) ## About The Pull Request The logic that sets the icon_state had an error in it. When the sign got emp'd, they'd get the `NOPOWER` flag which was causing them to get the `empty` `icon_state` instead of that of the emped barsign. This just fixes that by adding a conditional check for `EMPED`, and also resprites the emissive lightmask for the emped barsign to match the individual signs that make up its sprite, where previously it was just a static square. Also added it to the barsigns unit tests because I can see someone breaking this again. ## Why It's Good For The Game Fixes bug where emped barsigns would show the turned off sprite instead of their animated sprite. Also improves the light mask: Note: this is in complete darkness. The colored backdrops of the signs are not supposed to be emissive. <details> <summary>Before </summary>  </details> <details> <summary>After </summary>  </details>  ## Changelog :cl: fix: emped bar signs will now display the correct sprite image: added a more detailed lightmask for the emp bar sign sprite /:cl: --------- Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@ users.noreply.github.com> Co-authored-by: John Willard <53777086+JohnFulpWillard@ users.noreply.github.com> Co-authored-by: SyncIt21 <110812394+SyncIt21@ users.noreply.github.com> Co-authored-by: orange man <61334995+comfyorange@ users.noreply.github.com> Co-authored-by: Profakos <profakos@ gmail.com> Co-authored-by: Changelogs <action@ github.com> Co-authored-by: Jacquerel <hnevard@ gmail.com> Co-authored-by: Andrew <mt.forspam@ gmail.com> Co-authored-by: DaCoolBoss <142358580+DaCoolBoss@ users.noreply.github.com> * Fixes the EMP Barsign sprite not displaying --------- Co-authored-by: Bloop <[email protected]> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@ users.noreply.github.com> Co-authored-by: John Willard <53777086+JohnFulpWillard@ users.noreply.github.com> Co-authored-by: SyncIt21 <110812394+SyncIt21@ users.noreply.github.com> Co-authored-by: orange man <61334995+comfyorange@ users.noreply.github.com> Co-authored-by: Profakos <profakos@ gmail.com> Co-authored-by: Changelogs <action@ github.com> Co-authored-by: Jacquerel <hnevard@ gmail.com> Co-authored-by: Andrew <mt.forspam@ gmail.com> Co-authored-by: DaCoolBoss <142358580+DaCoolBoss@ users.noreply.github.com>
AnywayFarus
added a commit
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24951
Original PR: tgstation/tgstation#79599
About The Pull Request
The logic that sets the icon_state had an error in it. When the sign got emp'd, they'd get the
NOPOWERflag which was causing them to get theemptyicon_stateinstead of that of the emped barsign.This just fixes that by adding a conditional check for
EMPED, and also resprites the emissive lightmask for the emped barsign to match the individual signs that make up its sprite, where previously it was just a static square.Also added it to the barsigns unit tests because I can see someone breaking this again.
Why It's Good For The Game
Fixes bug where emped barsigns would show the turned off sprite instead of their animated sprite. Also improves the light mask:
Note: this is in complete darkness. The colored backdrops of the signs are not supposed to be emissive.
Before
After
Changelog
🆑 vinylspiders
fix: emped bar signs will now display the correct sprite
image: added a more detailed lightmask for the emp bar sign sprite
/:cl: