[MIRROR] Fixes tcomms relays being permanent (attempt 2) #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…B IGNORE] (#24963) * [NO GBP] Fixes tcomms relays being permanent (attempt 2) (#79558) ## About The Pull Request The problem was that the levels var of signals was being used as both a list for the levels the receivers can receive on and the levels broadcasters can broadcast on. So basically I caused this problem in #74788 because I removed receivers clearing the levels list after receiving the signal. This solved the problem of one receiver clearing the receiving list, preventing any other receivers from receiving the message. However, this led to the receiving levels sticking around to the point when the list was meant to be used for broadcasting levels. I originally tried to solve this problem in #78812 but this fix is much simpler. Another solution could be to make it so that there's separate vars for receiving levels and broadcasting levels instead of using the same var. idk if thats better or not though ## Why It's Good For The Game Fixes #78806 ## Changelog :cl: fix: Fixed tcomms relays being weird, they should be sabotagable again /:cl: * [NO GBP] Fixes tcomms relays being permanent (attempt 2) --------- Co-authored-by: BlueMemesauce <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 13, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Fixes weapon racks signal override * Update gun_racks.dm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24963
Original PR: tgstation/tgstation#79558
About The Pull Request
The problem was that the levels var of signals was being used as both a list for the levels the receivers can receive on and the levels broadcasters can broadcast on.
So basically I caused this problem in #74788 because I removed receivers clearing the levels list after receiving the signal. This solved the problem of one receiver clearing the receiving list, preventing any other receivers from receiving the message. However, this led to the receiving levels sticking around to the point when the list was meant to be used for broadcasting levels.
I originally tried to solve this problem in #78812 but this fix is much simpler.
Another solution could be to make it so that there's separate vars for receiving levels and broadcasting levels instead of using the same var. idk if thats better or not though
Why It's Good For The Game
Fixes #78806
Changelog
🆑 BlueMemesauce
fix: Fixed tcomms relays being weird, they should be sabotagable again
/:cl: