[MIRROR] drug fixes - kronkaine buff now stops after metabolizing out, removes some bad vars #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, removes some bad vars [MDB IGNORE] (#24964) * drug fixes - kronkaine buff now stops after metabolizing out, removes some bad vars (#79661) ## About The Pull Request - kronkaine's buff now ends after metabolizing (done by removing its id, which was more used for stimulant addictions anyway) - many drugs's moodlets now time out properly (done by removing the name parameter, since it made it multiply out to 0) ## Why It's Good For The Game maybe giving people permanent 2x do_after speed is Suboptimal maybe drug moodlets also shouldn't last forever somehow ## Changelog :cl: fix: Kronkaine's action speed buff now stops when metabolized out. fix: Drug-related moodlets should now time out properly. They still linger after metabolization ends, but they no longer last forever. /:cl: --------- Co-authored-by: Hatterhat <Hatterhat@ users.noreply.github.com> Co-authored-by: Jacquerel <hnevard@ gmail.com> * drug fixes - kronkaine buff now stops after metabolizing out, removes some bad vars --------- Co-authored-by: Hatterhat <[email protected]> Co-authored-by: Hatterhat <Hatterhat@ users.noreply.github.com> Co-authored-by: Jacquerel <hnevard@ gmail.com>
AnywayFarus
added a commit
that referenced
this pull request
Nov 13, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Fixes boulder processing mining point gain. (#81067) ## About The Pull Request Due to a misplaced multiplier, arcmining machines were eating their own point totals. Now, the refinery and smelter should correctly only take the MINING_POINT_MACHINE_MULTIPLIER define on the amount being added to the points held, not on the total resting in the machine. ## Why It's Good For The Game Simple, easy fix. Fixes #81057. ## Changelog :cl: fix: The smelter and refinery now properly hold mining points, only taking a small amount out of net gained points. /:cl: --------- Co-authored-by: SyncIt21 <[email protected]> * Fixes boulder processing mining point gain. --------- Co-authored-by: ArcaneMusic <[email protected]> Co-authored-by: SyncIt21 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24964
Original PR: tgstation/tgstation#79661
About The Pull Request
Why It's Good For The Game
maybe giving people permanent 2x do_after speed is Suboptimal
maybe drug moodlets also shouldn't last forever somehow
Changelog
🆑 Hatterhat
fix: Kronkaine's action speed buff now stops when metabolized out.
fix: Drug-related moodlets should now time out properly. They still linger after metabolization ends, but they no longer last forever.
/:cl: