[MIRROR] Makes achievements_score query database for count #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…E] (#24971) * Makes achievements_score query database for count (#79597) Instead of `/datum/award/score/achievements_score` counting achievement datums in-game and trying to keep up with what the database has we now just query the database for its current count of unlocked achievements by overriding the procs the achievements panel builds data from. This avoids cases like #79555. Count is still loaded to achievement data datum so it can be saved at round end. @ Time-Green * Makes achievements_score query database for count --------- Co-authored-by: Jordie <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Jan 25, 2024
* Adds a missing check to `can_look_up` (#81087) ## About The Pull Request `///Checks if the user is incapacitated or on cooldown.`. Adds the "or on cooldown" part of the proc into the proc. ## Changelog :cl: Melbert fix: Click CD applies to looking up and down correctly. /:cl: * Adds a missing check to `can_look_up` --------- Co-authored-by: MrMelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24971
Original PR: tgstation/tgstation#79597
Instead of
/datum/award/score/achievements_scorecounting achievement datums in-game and trying to keep up with what the database has we now just query the database for its current count of unlocked achievements by overriding the procs the achievements panel builds data from. This avoids cases like #79555.Count is still loaded to achievement data datum so it can be saved at round end.
@ Time-Green