Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes escape method in lavaland mafia map #614

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24985
Original PR: tgstation/tgstation#79696

About The Pull Request

Replaces the mining lockers in the lavaland Mafia map with mining carts.

Why It's Good For The Game

I forgot that these closets are populated with mining gear, allowing mafia players to PKA the door down and escape the play area. Oops!

Changelog

🆑 Rhials
fix: The full mining lockers in the Lavaland Mafia map have been replaced with (empty) mining carts.
/:cl:

…RE] (#24985)

* [NO GBP] Fixes escape method in lavaland mafia map (#79696)

## About The Pull Request

Replaces the mining lockers in the lavaland Mafia map with mining carts.
## Why It's Good For The Game

I forgot that these closets are populated with mining gear, allowing
mafia players to PKA the door down and escape the play area. Oops!
## Changelog
:cl: Rhials
fix: The full mining lockers in the Lavaland Mafia map have been
replaced with (empty) mining carts.
/:cl:

* [NO GBP] Fixes escape method in lavaland mafia map

---------

Co-authored-by: Rhials <[email protected]>
@ReezeBL ReezeBL merged commit e5257dc into master Nov 14, 2023
24 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-24985 branch November 14, 2023 08:02
AnywayFarus added a commit that referenced this pull request Nov 14, 2023
Iajret pushed a commit that referenced this pull request Jan 25, 2024
* Newspapers now use TGUI (#80991)

## About The Pull Request

Newspapers work as a static newscaster that is not affected by things
like D-notices and changing wanted issues after its been printed. It
doesn't store comments or get any updates after its been printed.
You can also scribble on the paper to leave notes on a specific page,
which is a feature I have never seen in my life but it is still here I
guess.

Minor things I've added:
- Sound effect when printing the newspaper in the first place
- 2 second do-after when scribbling just for some player feedback and
consistency
- Balloon alerts
- Context tips for scribbling and burning

I also fixed an issue with wanted issues on newscasters when there isn't
an image.
As a minor note, I replaced the instances of ``content`` in Buttons I
saw in newscaster's UI because it's marked as deprecated.

Too lazy to take a video sorry


![image](https://github.com/tgstation/tgstation/assets/53777086/6944965e-e949-4c22-a6a2-1dbe2f2d09c4)

![image](https://github.com/tgstation/tgstation/assets/53777086/5af44877-6170-424d-9766-46d1ad9f77be)

![image](https://github.com/tgstation/tgstation/assets/53777086/5c5cdfc5-541a-417e-a60d-9522227d0687)

## Why It's Good For The Game

Fixes an issue with newscasters and makes newspapers use a nice TGUI
that feels more responsive than before.
Helps further https://hackmd.io/XLt5MoRvRxuhFbwtk4VAUA even more.

## Changelog

:cl:
refactor: Newspapers now use TGUI.
fix: Fixed the newscaster's wanted section showing a non-existent photo.
/:cl:

* Newspapers now use TGUI

---------

Co-authored-by: John Willard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants