Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] tramstation virology is no longer depowered by a singular guaranteed rat roundstart #617

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24994
Original PR: tgstation/tgstation#79643

About The Pull Request

i put catwalk flooring over the cable

Why It's Good For The Game

fixes #79472

Changelog

🆑 mc-oofert
fix: The plaguebearer can no longer depower virology on Tramstation
/:cl:

…aranteed rat roundstart [MDB IGNORE] (#24994)

* tramstation virology is no longer depowered by a singular guaranteed rat roundstart (#79643)

## About The Pull Request

i put catwalk flooring over the cable

## Why It's Good For The Game

fixes #79472

## Changelog
:cl:
fix: The plaguebearer can no longer depower virology on Tramstation
/:cl:

Co-authored-by: Ghom <42542238+Ghommie@ users.noreply.github.com>

* tramstation virology is no longer depowered by a singular guaranteed rat roundstart

---------

Co-authored-by: jimmyl <[email protected]>
Co-authored-by: Ghom <42542238+Ghommie@ users.noreply.github.com>
@ReezeBL ReezeBL merged commit 7a19f46 into master Nov 14, 2023
24 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-24994 branch November 14, 2023 08:03
AnywayFarus added a commit that referenced this pull request Nov 14, 2023
Iajret pushed a commit that referenced this pull request Jan 25, 2024
* Fixes and updates the TEG (#81044)

## About The Pull Request

Fixes thermoelectric generators so they work again
Pipes can be connected to it, the machine can be rotated
Adds the ventcrawl movement flags as a defined bitfield
I also gave it a TGUI menu, it was small so it is pretty insignificant.
I added a little bit more text to error messages to make it clearer why
the thermoelectric generator isn't functional.
I also repathed generator to thermoelectric_generator because
'generator' is a keyword and is highlighted in green which makes people
using vscode a little confused what it's meant to be.

Old

![image](https://github.com/tgstation/tgstation/assets/53777086/0fe0651b-4d48-474b-869f-2f665757a0bc)

New

https://github.com/tgstation/tgstation/assets/53777086/064a5dda-5407-4817-b090-d22eb6c4aab8

## Why It's Good For The Game

This is one of the things I had to move to TGUI in
https://hackmd.io/XLt5MoRvRxuhFbwtk4VAUA
I was originally gonna remove it, but in the spirit of feature freeze I
thought I should at least give it a try.
This fixes many issues with it and gives it a new better UI that won't
stop updating easily so you can actually watch the changes as it
happens.
The TEG may not be obtainable in-game but it can still be mapped in or
give by admins, letting it function as intended is still a massive
benefit.

Closes tgstation/tgstation#75738

## Changelog

:cl: JohnFulpWillard, Unit2E teaching me the TEG
fix: The TEG now works again (still unobtainable by regular means
though).
fix: the TEG and its circulators can now be rotated counterclockwise
again.
refactor: The TEG now uses a TGUI interface rather than the old HTML
one.
/:cl:

---------

Co-authored-by: Ghom <[email protected]>

* Fixes and updates the TEG

---------

Co-authored-by: John Willard <[email protected]>
Co-authored-by: Ghom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants