Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] improve find_and_set/in_list behavior #621

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24995
Original PR: tgstation/tgstation#79614

About The Pull Request

improves the find_and_set behavior a bit. this is after and before observing 5 gorillas for 10 minutes
image
image

Why It's Good For The Game

improves the find_and_set/in_list behavior

Changelog

🆑 Ben10Omintrix
not player facing
/:cl:

* improve find_and_set/in_list behavior (#79614)

## About The Pull Request
improves the find_and_set behavior a bit. this is after and before
observing 5 gorillas for 10 minutes

![image](https://github.com/tgstation/tgstation/assets/138636438/d8f5cdcb-71bd-41bd-a069-10b0367224ec)

![image](https://github.com/tgstation/tgstation/assets/138636438/1fd70fea-5769-4021-95ec-038137ce7423)

## Why It's Good For The Game
improves the find_and_set/in_list behavior

## Changelog
:cl:
not player facing
/:cl:

* improve find_and_set/in_list behavior

---------

Co-authored-by: Ben10Omintrix <[email protected]>
@ReezeBL ReezeBL merged commit 6654ebd into master Nov 14, 2023
24 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-24995 branch November 14, 2023 08:05
Iajret pushed a commit that referenced this pull request Jan 25, 2024
* Removes infinite sources of plasma from icebox (#81091)

## About The Pull Request

The gibotonite that arcane had setup to spawn on icebox was uh, the
wrong kind, it was the cursed SNOWDIN gibonite, which is made to live in
a plasma environment. Rookie error really should have remembered that
ice/icemoon exists this is a GREAT codebase

Speaking of, I've noticed that gibonite is the only ore that spawns in
an actual mineral wall here (IE the blue rock walls) so you can really
trivially avoid it. that feels wrong

## Changelog
:cl:
fix: Icebox will no longer spawn a fuck ton of plasma after gibonite
blows. YW besties
/:cl:

* Removes infinite sources of plasma from icebox

---------

Co-authored-by: LemonInTheDark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants