[MIRROR] [MODULAR] Fixes a bug whereby loadout plushes with a custom desc could revert to the default desc #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d revert to the default desc (#24884) * Fixes a bug whereby loadout plushes could rename themselves to the initial desc rather than the custom one * Whoops
AnywayFarus
added a commit
that referenced
this pull request
Nov 15, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 27, 2024
* Legion Mob Abilities (#81082) ## About The Pull Request Converts legions hardcoded abilities to the cooldown action / mob abilities system. I also took the liberty of converting the hacky 360 second cooldowns in a lot of the mob actions into simply disabling other abilities while the ability is active, this will make it easier to have bosses without everything on a shared cooldown and also not allow abilities to be used simultaneously. ## Why It's Good For The Game Paving the way for basic megafauna. ## Changelog :cl: refactor: Legions abilities have been changed into actions that can be added to any mob. /:cl: --------- Co-authored-by: Changelogs <[email protected]> * Legion Mob Abilities --------- Co-authored-by: Whoneedspacee <[email protected]> Co-authored-by: Changelogs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: Skyrat-SS13/Skyrat-tg#24884
About The Pull Request
Fixes Skyrat-SS13/Skyrat-tg#24833
Adds two procs
on_loadout_custom_named()andon_loadout_custom_described(), which can be overridden in situations like this where you want something to happen after applying a custom loadout name/desc.In the case of plushes, they had a second desc var that needed to be set as well.
How This Contributes To The Skyrat Roleplay Experience
Bugfix
Changelog
🆑 vinylspiders
fix: fixed a bug where loadout plushes would sometimes have their custom descriptions reset under certain conditions
/:cl: