[MIRROR] [MODULAR] Anesthetic mask will give an error message when placed via mapping #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mapping (#24913) * Anesthetic mask will give an error message when placed via mapping It shouldn't be allowed to pass CI if it does. * Don't let them spawn outside of a machine * Update anesthetic_machine.dm * Gets rid of remaining anesthetic masks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: Skyrat-SS13/Skyrat-tg#24913
About The Pull Request
These should cause CI to fail when placed via mapping. Now, they will! They will also self-delete if accidentally spawned via adminnery.
Also fixed a lot of bugs with the code. They were storing a hard ref in a weakref...fixed it so they actually use a real weakref, now, instead of trying to pretend the hardref was a weakref.
How This Contributes To The Skyrat Roleplay Experience
Fixes bugs, makes anesthetic machine work better. Players picking up NODROP items is bad.
Proof of Testing
Still works
The new runtimes
Changelog
🆑 vinylspiders
refactor: fixed hard dels associated with anesthetic machine, & the mask item will now cause ci to fail when placed via mapping
fix: you no longer have to violently beat the anesthetic machine to death with the anesthetic tank to load it
fix: fixed a bug that would cause the anesthetic machine to become unusable when a mask gets destroyed (e.g., in a fire or explosion)
/:cl: