[MIRROR] Fixes a small issue with disposal outlets. #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…018) * Fixes a small issue with disposal outlets. (#79706) ## About The Pull Request Disposal outlets eject the contents of the holder with a 2 seconds delay. Delete the outlet before the delay is over and the contents will stay stuck inside the holder. Also merging disposal holders doesn't properly register a signal for mobs transfered to the new holder. ## Why It's Good For The Game Bugfixing. Disposal code is a mess. Perhaps related to #79629 but I couldn't exactly reproduce it. ## Changelog :cl: fix: Fixed a small issue with disposal outlets leaving contents about to be ejected stuck inside the pipe beneath it if deleted. /:cl: * Fixes a small issue with disposal outlets. --------- Co-authored-by: Ghom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25018
Original PR: tgstation/tgstation#79706
About The Pull Request
Disposal outlets eject the contents of the holder with a 2 seconds delay. Delete the outlet before the delay is over and the contents will stay stuck inside the holder.
Also merging disposal holders doesn't properly register a signal for mobs transfered to the new holder.
Why It's Good For The Game
Bugfixing. Disposal code is a mess. Perhaps related to #79629 but I couldn't exactly reproduce it.
Changelog
🆑 Ghommie
fix: Fixed a small issue with disposal outlets leaving contents about to be ejected stuck inside the pipe beneath it if deleted.
/:cl: