[MIRROR] Heart code cleanup #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Heart code cleanup (#79602) ## About The Pull Request General clean up of heart code. - Use `Stop` and `Restart` in `set_heart_attack` - Use `SEND_SOUND()` rather than `playsound_local` for heartbeats - Use `update_icon_blocker` - Correctly ensures ethereal hearts get their overlay - Adds heartbeat animation to ethereal hearts ## Changelog :cl: Melbert code: General heart code cleanup. fix: Heartbeat sound effects are no longer sourced to the exact tile you fell into crit at fix: Abductors glands are less likely to become invisible or look wrong fix: Ethereal hearts are less likely to become invisible or look wrong, and now properly spawn with their shine overlay image: Adds heartbeat animation to beating Ethereal Hearts /:cl: * Heart code cleanup --------- Co-authored-by: MrMelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25019
Original PR: tgstation/tgstation#79602
About The Pull Request
General clean up of heart code.
StopandRestartinset_heart_attackSEND_SOUND()rather thanplaysound_localfor heartbeatsupdate_icon_blockerChangelog
🆑 Melbert
code: General heart code cleanup.
fix: Heartbeat sound effects are no longer sourced to the exact tile you fell into crit at
fix: Abductors glands are less likely to become invisible or look wrong
fix: Ethereal hearts are less likely to become invisible or look wrong, and now properly spawn with their shine overlay
image: Adds heartbeat animation to beating Ethereal Hearts
/:cl: