[MIRROR] General code maintenance for smart fridge #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* General code maintenance for smart fridge * Update smartfridge.dm --------- Co-authored-by: SyncIt21 <[email protected]> Co-authored-by: Bloop <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 15, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 27, 2024
* Minor code cleanup for PCM (#81092) ## About The Pull Request - Shortened the description for readability. Makes sense to display further details only when examining. - Removed deprecated `content` tag from button elements in the UI - Added more sanity checks when dealing with numbers inside `ui_act()` - Make sure we don't insert hologram items - Use `as anything` to speed up some for loops - Capitalized some text inside examine ## Changelog :cl: spellcheck: shortened description for the PCM and capitalized some text for its examines. code: adds sanity checks and removed deprecated `content` tag from PCM UI. Stops hologram items from being inserted. /:cl: * Minor code cleanup for PCM --------- Co-authored-by: SyncIt21 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25020
Original PR: tgstation/tgstation#79623
About The Pull Request
Overall code optimizations for smart fridges. The gist of it includes.
is_type_in_list()in some places to reduce the redundantistype()checksQol improvements include.
Changelog
🆑 SyncIt21
fix: drying rack now shows correct examines & screen tips.
code: tone of code organization for smart fridges overall. changed ui to typescript.
qol: added more detailed examines & screen tips for smart fridges. drying racks can be dismantled with a crowbar and not simply pried open with it.
/:cl: