Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Blueshift - Let's try to get rid of those crashes #652

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: Skyrat-SS13/Skyrat-tg#24978

About The Pull Request

This PR doesnt change any room designs as i'm hoping the changes i did make resolve the issues we're having. It removes thousands of VV'd tiles and decals and replaces them with their proper alternative. It also gets rid of the many 1 tile decal bukkake's when i found them including the dark tiles that are overlayed with the light decal making them just a grey tile...

Players probably wont really notice a large difference except in maybe security where the decals were cut back a large bit, mainly the walkways are goin for a 1-stripe vibe to see how that plays out visually.

And while an empty local server doesnt do much to compare to a live one, this change lowered the RAM usage by 150 MB, closer to what Icebox uses by about a 200 MB difference

Edit: after the repiping of atmos it now uses less RAM than Icebox

How This Contributes To The Skyrat Roleplay Experience

Hopefully let's the server RP again

Proof of Testing

Screenshots/Videos

I'd just have to screenshot the entire map given i went through every area and redid the decals and removed over a thousand of them.

However the below is validating the airless variants are working appropriately.

image

Changelog

🆑 Zergspower
fix: fixes the mass-decal and VV's in Blueshift - additionally repipes the entire map to reduce its size
/:cl:

* Attemp 1

* forgor to hit save

* Update iron_floor.dm

* Revert "Update iron_floor.dm"

This reverts commit 01c644c1395106417f1ae9d9ef24839832bd95a4.

* Atmos go brrrrrr

* 2

* afix
@Iajret Iajret merged commit cf0042b into master Nov 16, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-24978 branch November 16, 2023 09:10
AnywayFarus added a commit that referenced this pull request Nov 16, 2023
Iajret pushed a commit that referenced this pull request Jan 28, 2024
* [NO GBP] Fixes autolathe power usage for printing items (#81116)

## About The Pull Request
- Fixes #81115

Right we have to start the sum from `0` my bad. Also uses material
define constant when inserting sheets instead of constant `100`

## Changelog
:cl:
fix: auto lathes don't hog local apc supply when printing items
/:cl:

* [NO GBP] Fixes autolathe power usage for printing items

---------

Co-authored-by: SyncIt21 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants