Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] humans now have soul departed desc when brainless or when the client is disconnected #655

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25027
Original PR: tgstation/tgstation#79730

About The Pull Request

what the title says, previously we used to say that bodies without brains were just lifeless, thats swapped. the key checks were changed to be client checks

Why It's Good For The Game

it makes more sense to say theyre soul departed when theres no brain because there is no soul in them, even if thats technically implied by the brain not being there.
for the client thing - its immediate knowledge to the doctor that theres more important people to prioritize than the guy that ragequit so they don't have to waste 10 minutes working on them. If they come back the morgue will beep and become green.

Changelog

🆑 Fikou
qol: Dead human examines count as "soul departed" when the client is disconnected or the human doesn't have a brain anymore.
/:cl:

…e client is disconnected [MDB IGNORE] (#25027)

* humans now have soul departed desc when brainless or when the client is disconnected (#79730)

## About The Pull Request
what the title says, previously we used to say that bodies without
brains were just lifeless, thats swapped. the key checks were changed to
be client checks

## Why It's Good For The Game
it makes more sense to say theyre soul departed when theres no brain
because there is no soul in them, even if thats technically implied by
the brain not being there.
for the client thing - its immediate knowledge to the doctor that theres
more important people to prioritize than the guy that ragequit so they
don't have to waste 10 minutes working on them. If they come back the
morgue will beep and become green.

## Changelog
:cl:
qol: Dead human examines count as "soul departed" when the client is
disconnected or the human doesn't have a brain anymore.
/:cl:

* humans now have soul departed desc when brainless or when the client is disconnected

---------

Co-authored-by: Fikou <[email protected]>
@Iajret Iajret merged commit 7959dc0 into master Nov 16, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-25027 branch November 16, 2023 09:30
AnywayFarus added a commit that referenced this pull request Nov 16, 2023
Iajret pushed a commit that referenced this pull request Jan 28, 2024
* Fixes flashers on tramstation/birdshot (#81104)

## About The Pull Request
didnt have a id set, i set a id
## Why It's Good For The Game
Pressing the flasher should do something
## Changelog
:cl:

fix:  The buttons for flashers on birdshot/tramstation now work

/:cl:

* Fixes flashers on tramstation/birdshot

---------

Co-authored-by: rageguy505 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants