[MIRROR] Codifies male goats not having an udder #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Codifies male goats not having an udder (#79722) ## About The Pull Request This was addressed in #78759 (1b1fde4908826ef5c54ffc0734e74028270af3fd) and reviewed (and merged even though I didn't respond to it, oh well), but I half-assed it because the whole point was to prevent male goats from having an udder, but I only added it to the subtype of Pete i made in that PR. Let's expand that to all male goats now. ## Why It's Good For The Game It doesn't make biological nor morphological sense as to why a male goat can provide milk. Ideally this should be like this for all animals (because that's real life) but that's a later issue with further balance implication. I think it's still an interesting idea that Nanotrasen will just send you any old goat despite it being "useless" beyond being very good at eating plants. Maybe cargo should have a way to guarantee getting a female goat in the future? It's just like real life where zoos and farms have to constantly dealw ith female animals (such as giraffes or other exotic stuff) tending to be far rarer/cost far more than their male variants due to the potential to generate offspring (there's more nuance to husbandry than this but just play along)... and in space, every animal is "exotic". It still remains possible to biogenerate milk, which tends to be far faster than feeding/milking goats- which is something that the cook should have access to anyways. ## Changelog :cl: balance: Male Goats should no longer spawn with an udder, instead of it just being Pete. /:cl: --------- Co-authored-by: Ghom <42542238+Ghommie@ users.noreply.github.com> * Codifies male goats not having an udder --------- Co-authored-by: san7890 <[email protected]> Co-authored-by: Ghom <42542238+Ghommie@ users.noreply.github.com>
AnywayFarus
added a commit
that referenced
this pull request
Nov 16, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 26, 2024
…ble roundstart MODsuit (#656) * Initial pass of Entombed quirk * Fix incorrect preference path * Fix improper preferences path * Add entombed damage processing & toggle prefs for forced no-deploy * Sort tgui imports and use the not broken text input * Simplify toxin damage from entombed and remove fused MODsuit indestructible flag * Handle custom stripping behavior on entombed MODsuits with storage modules * Improve messaging on strip override * Replace CMO modsuit w/ corpsman reskin & add infiltrator entombed skin * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * Stack trace and qdel on null modsuit in add_unique(), code formatting improvements * Extend equipping quirks to record what items they force-drop, and make Entombed transfer old bag contents into its MODsuit storage * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * Add foley jitter to the life support failure process (makes it clearer what's killing the user) * Handle dropped force-equipped items qdels gracefully Co-authored-by: Bloop <[email protected]> * Ensure customizations are applied to the entombed MODsuit * Force deployed MODsuits give the no dismember trait, increase max chars on name customization to 48 & remove broken colonist skin * Remove entombed MODsuit activation to post_add() to avoid loadout shenanigans --------- Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25030
Original PR: tgstation/tgstation#79722
About The Pull Request
This was addressed in #78759 (1b1fde4908826ef5c54ffc0734e74028270af3fd) and reviewed (and merged even though I didn't respond to it, oh well), but I half-assed it because the whole point was to prevent male goats from having an udder, but I only added it to the subtype of Pete i made in that PR. Let's expand that to all male goats now.
Why It's Good For The Game
It doesn't make biological nor morphological sense as to why a male goat can provide milk. Ideally this should be like this for all animals (because that's real life) but that's a later issue with further balance implication.
I think it's still an interesting idea that Nanotrasen will just send you any old goat despite it being "useless" beyond being very good at eating plants. Maybe cargo should have a way to guarantee getting a female goat in the future? It's just like real life where zoos and farms have to constantly dealw ith female animals (such as giraffes or other exotic stuff) tending to be far rarer/cost far more than their male variants due to the potential to generate offspring (there's more nuance to husbandry than this but just play along)... and in space, every animal is "exotic".
It still remains possible to biogenerate milk, which tends to be far faster than feeding/milking goats- which is something that the cook should have access to anyways.
Changelog
🆑 san7890
balance: Male Goats should no longer spawn with an udder, instead of it just being Pete.
/:cl: