[MIRROR] Flips the supermatter filters on Birdshot to have them work like other maps. #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…like other maps. [MDB IGNORE] (#25033) * Flips the supermatter filters on Birdshot to have them work like other maps. (#79669) ## About The Pull Request  This PR flips the ~~bird~~ filters on the Birdshot Supermatter engine. Now they work like other maps, where the filtered gas is the one that says in the engine, rather than getting filtered out. ## Why It's Good For The Game Currently like half the rounds on Birdshot (I actually wonder if I'm even hyperbolic or if its not actually lowballing it) happen to have a supermatter delamination early into the round because the design has a critical part that's so different to other maps. I didn't make it an inverse filter by default since it makes the maps a bit more consistent, but more importantly, makes bad-faith players intentionally sabotaging the supermatter way, way more obvious. ## Changelog :cl: qol: The supermatter filters have been flipped on BirdshotStation to work like the supermatters on every round, meaning the filtered gas goes in, and the non-filtered gas comes out. /:cl: * Flips the supermatter filters on Birdshot to have them work like other maps. --------- Co-authored-by: CRITAWAKETS <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 16, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 29, 2024
* Dynamic Husk Icons * Update _bodyparts.dm * Screenshot test --------- Co-authored-by: 13spacemen <[email protected]> Co-authored-by: Mal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25033
Original PR: tgstation/tgstation#79669
About The Pull Request
This PR flips the
birdfilters on the Birdshot Supermatter engine. Now they work like other maps, where the filtered gas is the one that says in the engine, rather than getting filtered out.Why It's Good For The Game
Currently like half the rounds on Birdshot (I actually wonder if I'm even hyperbolic or if its not actually lowballing it) happen to have a supermatter delamination early into the round because the design has a critical part that's so different to other maps.
I didn't make it an inverse filter by default since it makes the maps a bit more consistent, but more importantly, makes bad-faith players intentionally sabotaging the supermatter way, way more obvious.
Changelog
🆑 CRITAWAKETS
qol: The supermatter filters have been flipped on BirdshotStation to work like the supermatters on every round, meaning the filtered gas goes in, and the non-filtered gas comes out.
/:cl: