[MIRROR] Adds a Chat Reliability Layer #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds a Chat Reliability Layer (#79479) ## About The Pull Request Everyone knows that chat will just eat your messages now and then, isn't that annoying? What if SSchat was smart enough to keep track of your messages and notice when you didn't get one? Well, now it can! ## Why It's Good For The Game Chat messages poofing into the aether is bad, really bad. ## Changelog :cl: add: Chat Reliability Layer code: TGUI chat messages now track their sequence and will be resent if the client notices a discrepenency /:cl: --------- Co-authored-by: Kyle Spier-Swenson <kyleshome@ gmail.com> * Adds a Chat Reliability Layer --------- Co-authored-by: Zephyr <[email protected]> Co-authored-by: Kyle Spier-Swenson <kyleshome@ gmail.com>
AnywayFarus
added a commit
that referenced
this pull request
Nov 18, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 29, 2024
…a result of mineral balance (#681) * Arcane makes good on his promise to get rid of lathe tax as a result of mineral balance (#81151) ## About The Pull Request    With the merge of #78524, we have a significant amount more control over how many materials are entering the round, as if it's overtuned, we can adjust the mineral spawning percentages, and if it's undertuned we can do vice-versa. Similarly with ore vents, we can adjust how much of every resource will spawn, allowing for items that can be printed via the lathe to have a significant more impact on how much they cost depending on round balance. Going forward, this data can be found using the mineral logging and graphing tool found in `tools\silo_grapher\silo_graph_script.py` to make future balance decisions. These tools combined allow for a full suite of resource controls going in and out of the round for decisions to be made on item printing. ## Why It's Good For The Game We needed better control on resources going in and out of the round for the massive, massive quantity of items in game limited by being extremely cheap to print on the lathe. We have those resource controls now, and the tools to adjust the balance as necessary. Therefore, I'm fine with us axing this. Fixes #67009, and fixes #66601. I would wait out the last bit of the freeze but ahh fuck it I don't see why not to do it now ## Changelog :cl: del: The lathe tax on printing items has been removed from the game for both humans and silicons. /:cl: * Arcane makes good on his promise to get rid of lathe tax as a result of mineral balance --------- Co-authored-by: ArcaneMusic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25068
Original PR: tgstation/tgstation#79479
About The Pull Request
Everyone knows that chat will just eat your messages now and then, isn't that annoying?
What if SSchat was smart enough to keep track of your messages and notice when you didn't get one?
Well, now it can!
Why It's Good For The Game
Chat messages poofing into the aether is bad, really bad.
Changelog
🆑 ZephyrTFA
add: Chat Reliability Layer
code: TGUI chat messages now track their sequence and will be resent if the client notices a discrepenency
/:cl: