[MIRROR] Mob attackedby / check_block refactor, plus some minor cleanup of attack_x procs
#692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leanup of `attack_x` procs [MDB IGNORE] (#25079) * Mob `attackedby` / `check_block` refactor, plus some minor cleanup of `attack_x` procs * Fix the race condition * Modular * Ooops --------- Co-authored-by: MrMelbert <[email protected]> Co-authored-by: Giz <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 18, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 30, 2024
* Cult pylons won't convert floorless floors (#81171) ## About The Pull Request Cult pylons read from our existing list of "turfs which don't count as floor despite being open turfs" instead of having its own one, which did not include openspace turfs. This prevents it from "papering over" things like stairwells and sealing people inside their base.  ## Why It's Good For The Game It's not supposed to do that, and fixing it this way is futureproof to a greater degree. ## Changelog :cl: fix: Cult pylons will no longer cover up "open space" (or water) with cult floors /:cl: * Cult pylons won't convert floorless floors --------- Co-authored-by: Jacquerel <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Cult pylons won't convert floorless floors (#81171) ## About The Pull Request Cult pylons read from our existing list of "turfs which don't count as floor despite being open turfs" instead of having its own one, which did not include openspace turfs. This prevents it from "papering over" things like stairwells and sealing people inside their base.  ## Why It's Good For The Game It's not supposed to do that, and fixing it this way is futureproof to a greater degree. ## Changelog :cl: fix: Cult pylons will no longer cover up "open space" (or water) with cult floors /:cl: * Cult pylons won't convert floorless floors --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Jacquerel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25079
Original PR: tgstation/tgstation#79563
About The Pull Request
spec_attacked_bycheck_shieldsdown to the living level, renames it tocheck_blockattack_xprocs, but not a lot. Should have an entire PR dedicated to this .... mess./obj/item/meleeWhy It's Good For The Game
Second verse, same as the first.
Changelog
🆑 Melbert
refactor: Refactored another large chuck of attack code, primarily involving melee item attacks and non-human mob attacks. Report if you see anything weird
fix: Pacifists clicking on simple robots or silicons no longer causes sparks
fix: Blocked thrown batons are now properly... blocked
/:cl: